Discuss the need of a variables section in test templates

[eriqua]

Should dependencies resource names be defined in a variables section or directly in the resource section? Adding variables would lead to a bigger file but would avoid duplication in case multiple occurrences of the same name are needed

Suggestion is: Variables should be avoided in test files (dependencies.bicep and deploy.test.bicep) unless their value is required in multiple places.
Further discussion is needed for the whole team to agree.

If agreed upon, this issue is about providing corresponding guidelines in the contribution guide wiki section.

[AlexanderSehr]

A couple additional points from our recent discussion

• Instead of variables for e.g. the virtualNetworkName we should rather introduce parameters instead (having the value as a default) as this would be closer aligned to a best pratice in a solution scenario
• However, we'd need to establish how far we want to push this. For example
  • Does this only count for the dependency values in the deploy.test.bicep?
  • Does that also count for everything in the dependencies.bicep - and as such also all values?
  • At what point do we introduce to much added complexity?

[rahalan]

• create a disclaimer how to use test files (they should not be considered as solutions, but actual test files)
• variables should only used where really necessary (limit the usage as much as possible)