VirtualNetwork: issue with overlapping addresses for vnetpeering

[eriqua]

Description

Virtual network peering child resource fails with the following error

{
    "status": "Failed",
    "error": {
        "code": "VnetAddressSpaceOverlapsWithAlreadyPeeredVnet",
        "message": "Cannot create or update peering /subscriptions/a7439831-1cd9-435d-a091-4aa863c96556/resourceGroups/validation-rg/providers/Microsoft.Network/virtualNetworks/sxx-az-vnet-x-001/virtualNetworkPeerings/sxx-az-vnet-x-001-adp-sxx-az-vnet-x-peer01. Virtual networks /subscriptions/a7439831-1cd9-435d-a091-4aa863c96556/resourceGroups/validation-rg/providers/Microsoft.Network/virtualNetworks/sxx-az-vnet-x-001 and /subscriptions/a7439831-1cd9-435d-a091-4aa863c96556/resourceGroups/validation-rg/providers/Microsoft.Network/virtualNetworks/adp-sxx-az-vnet-x-peer01 cannot be peered because address space of the first virtual network overlaps with address space of virtual network /subscriptions/a7439831-1cd9-435d-a091-4aa863c96556/resourceGroups/validation-rg/providers/Microsoft.Network/virtualNetworks/sxx-az-vnet-peer-x-002 already peered with the second virtual network. Overlapping address prefixes: 10.0.0.0/24.",
        "details": []
    }
}

Steps to reproduce

1. Run the Virtual network pipeline
2. Double check the deployment in portal

Screenshots

[AlexanderSehr]

I'll hold off with that until PR #707 is merged. I don't recall that issue there

[eriqua]

Testing environment relsted. Fixed after deletion of vnet peers on dependency vnet, probably deployed manually.