Keyvaults - Securing secrets parameter by using object#1022
Merged
AlexanderSehr merged 4 commits intoAzure:mainfrom Feb 21, 2022
Merged
Keyvaults - Securing secrets parameter by using object#1022AlexanderSehr merged 4 commits intoAzure:mainfrom
AlexanderSehr merged 4 commits intoAzure:mainfrom
Conversation
AlexanderSehr
requested changes
Feb 21, 2022
Contributor
AlexanderSehr
left a comment
There was a problem hiding this comment.
Please also update the parameters.json file.
"secrets": {
"value": {
"secureList": [
{
"name": "secretName",
"value": "secretValue",
"contentType": "Something",
"attributesExp": 1702648632,
"attributesNbf": 10000,
"roleAssignments": [
{
"roleDefinitionIdOrName": "Reader",
"principalIds": [
"<<deploymentSpId>>"
]
}
]
}
]
}
}
Contributor
|
Hey @vgaupset, thanks for the contribution. Just checked it out locally and suggested a few minor changes (rename + parameter file). Thanks for you contribution :) |
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Contributor
Author
|
@MrMCake No problem :) I have changed the PR in compliance with requested changes. |
AlexanderSehr
approved these changes
Feb 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Converting
secretsparameter to secure object. The array type does not have thesecureoption and will therefore be displayed in plaintext in Azure portal (in deployments or export template).Type of Change
Please delete options that are not relevant.
(Due to change from array to object)
Checklist