Simplify VM availability zone parameters#1030
Merged
MariusStorhaug merged 7 commits intomainfrom Feb 23, 2022
Merged
Conversation
Unit Test Results 1 files ± 0 1 suites ±0 33s ⏱️ -16s Results for commit c38732b. ± Comparison against base commit 42ea3fb. This pull request removes 14 and adds 10 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Contributor
|
@rahalan , thoughts? |
Contributor
looks good to me |
rahalan
previously approved these changes
Feb 22, 2022
eriqua
reviewed
Feb 22, 2022
AlexanderSehr
approved these changes
Feb 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
VM availability set is now changed to only require
availabilityZoneto place the VM in an availability zone. Providing 0 (the default value) disabled the use of availability zones.The following link is to a test run providing 0 as a hardcoded value to the
zonesproperty, where you see0is not an accepted value.https://github.com/Azure/ResourceModules/runs/5279888499?check_suite_focus=true#step:4:368
Type of Change
Please delete options that are not relevant.
Checklist