Skip to content

Fix incorrect parameter handling in Automation Account#1037

Merged
AlexanderSehr merged 1 commit intomainfrom
users/alsehr/autoAccountBool
Feb 28, 2022
Merged

Fix incorrect parameter handling in Automation Account#1037
AlexanderSehr merged 1 commit intomainfrom
users/alsehr/autoAccountBool

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

Change

  • The module throws an error because of the usage of empty(bool) which is not supported
  • Furthermore, the conditions seem unneccesary complicated

Pipeline reference
Automation: AutomationAccounts

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

@AlexanderSehr AlexanderSehr self-assigned this Feb 23, 2022
@AlexanderSehr AlexanderSehr added [cat] modules category: modules bug Something isn't working labels Feb 23, 2022
@AlexanderSehr AlexanderSehr added this to the v 0.5 milestone Feb 23, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 23, 2022

Unit Test Results

    1 files  ±    0    1 suites  ±0   1m 33s ⏱️ +59s
  20 tests +  10  20 ✔️ +10      0 💤 ±    0  0 ±0 
239 runs  +163  20 ✔️ +10  219 💤 +153  0 ±0 

Results for commit 1f609e6. ± Comparison against base commit 0752ff8.

This pull request removes 10 and adds 20 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachines/extensions] used resource type [virtualMachines/extensions] should use on of the recent API version(s). Currently using [2021-07-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachines] used resource type [configurationProfileAssignments] should use on of the recent API version(s). Currently using [2021-04-30-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachines] used resource type [diagnosticsettings] should use on of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachines] used resource type [locks] should use on of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachines] used resource type [networkInterfaces] should use on of the recent API version(s). Currently using [2021-03-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachines] used resource type [publicIPAddresses] should use on of the recent API version(s). Currently using [2021-05-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachines] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2021-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachines] used resource type [vaults/backupFabrics/protectionContainers/protectedItems] should use on of the recent API version(s). Currently using [2021-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachines] used resource type [virtualMachines/extensions] should use on of the recent API version(s). Currently using [2021-07-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachines] used resource type [virtualMachines] should use on of the recent API version(s). Currently using [2021-07-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts/jobSchedules] used resource type [automationAccounts/jobSchedules] should use on of the recent API version(s). Currently using [2020-01-13-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts/modules] used resource type [automationAccounts/modules] should use on of the recent API version(s). Currently using [2020-01-13-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts/runbooks] used resource type [automationAccounts/runbooks] should use on of the recent API version(s). Currently using [2019-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts/schedules] used resource type [automationAccounts/schedules] should use on of the recent API version(s). Currently using [2020-01-13-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts/softwareUpdateConfigurations] used resource type [automationAccounts/softwareUpdateConfigurations] should use on of the recent API version(s). Currently using [2019-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts/variables] used resource type [automationAccounts/variables] should use on of the recent API version(s). Currently using [2020-01-13-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts] used resource type [automationAccounts/jobSchedules] should use on of the recent API version(s). Currently using [2020-01-13-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts] used resource type [automationAccounts/modules] should use on of the recent API version(s). Currently using [2020-01-13-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts] used resource type [automationAccounts/runbooks] should use on of the recent API version(s). Currently using [2019-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts] used resource type [automationAccounts/schedules] should use on of the recent API version(s). Currently using [2020-01-13-preview]
…

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit d85046a into main Feb 28, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/autoAccountBool branch February 28, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working [cat] modules category: modules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants