Skip to content

Adding private dns zones children#1044

Merged
rahalan merged 54 commits intomainfrom
users/rahalan/addPrivateDnsZonesChildren
Mar 4, 2022
Merged

Adding private dns zones children#1044
rahalan merged 54 commits intomainfrom
users/rahalan/addPrivateDnsZonesChildren

Conversation

@rahalan
Copy link
Copy Markdown
Contributor

@rahalan rahalan commented Feb 25, 2022

Change

Adding DNS entries

Network: PrivateDnsZones

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@rahalan rahalan enabled auto-merge (squash) February 25, 2022 08:54
Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we follow the azure resource reference convention and go with capital letters for privateDnsZones children? e.g. A, AAAA, CNAME, ...

@rahalan
Copy link
Copy Markdown
Contributor Author

rahalan commented Feb 28, 2022

Should we follow the azure resource reference convention and go with capital letters for privateDnsZones children? e.g. A, AAAA, CNAME, ...

I had that before, but that also means we need to have capital directory names, which is different than would we do with all other modules. So I changed it to small letters. But I can change it back, if the team wants to go for capital letters, no problem

rahalan and others added 17 commits March 1, 2022 12:53
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 2, 2022

Unit Test Results

    1 files  1 suites   1m 49s ⏱️
    9 tests 9 ✔️     0 💤 0
320 runs  9 ✔️ 311 💤 0

Results for commit fa2799f.

♻️ This comment has been updated with latest results.

@rahalan rahalan merged commit 59d2602 into main Mar 4, 2022
@rahalan rahalan deleted the users/rahalan/addPrivateDnsZonesChildren branch March 4, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants