Skip to content

StorageAccount: Cleanup + add publicNetworkAccess parameter#1086

Merged
MariusStorhaug merged 19 commits intomainfrom
users/mast/SA_publicNetworkAccess
Mar 5, 2022
Merged

StorageAccount: Cleanup + add publicNetworkAccess parameter#1086
MariusStorhaug merged 19 commits intomainfrom
users/mast/SA_publicNetworkAccess

Conversation

@MariusStorhaug
Copy link
Copy Markdown
Contributor

@MariusStorhaug MariusStorhaug commented Mar 5, 2022

Change

Clean-up Storage Account properties/variables and add some missing properties

Problem statement:
The requiredInfrastructureEncryption looked good, but didn't work. We loose tool support when authoring (intellisense and linter) by having nested vars. It didn't show a warning when in a var, but bringing it in to the resource declaration and under property, it showed the issue.

Adding:

  • publicNetworkAccess
  • move enableInfrastructureEncryption (was placed wrong and was not correctly configuring the setting before)
  • ...

Storage: StorageAccounts

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 5, 2022

Unit Test Results

    1 files    1 suites   2m 28s ⏱️
  42 tests 42 ✔️     0 💤 0
386 runs  42 ✔️ 344 💤 0

Results for commit b054921.

♻️ This comment has been updated with latest results.

@MariusStorhaug MariusStorhaug marked this pull request as ready for review March 5, 2022 16:10
@MariusStorhaug MariusStorhaug enabled auto-merge (squash) March 5, 2022 16:13
@MariusStorhaug MariusStorhaug deleted the users/mast/SA_publicNetworkAccess branch March 5, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants