Skip to content

VPN Site: Created new module#1088

Merged
MariusStorhaug merged 9 commits intomainfrom
users/alsehr/982_vpnSite
Mar 5, 2022
Merged

VPN Site: Created new module#1088
MariusStorhaug merged 9 commits intomainfrom
users/alsehr/982_vpnSite

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@AlexanderSehr AlexanderSehr commented Mar 5, 2022 •
edited
Loading

Change

  • Created new VPN Site module (to get it out of the vWan module)
  • Added pipelines & readmes
  • Updated a test to give better feedback

Pipeline reference: IaCS

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

@AlexanderSehr AlexanderSehr self-assigned this Mar 5, 2022
@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Mar 5, 2022
@AlexanderSehr AlexanderSehr added this to the v 0.5 milestone Mar 5, 2022
@AlexanderSehr AlexanderSehr linked an issue Mar 5, 2022 that may be closed by this pull request
vWAN: Move modules out of vWAN #982
Closed
MariusStorhaug
MariusStorhaug suggested changes Mar 5, 2022
View reviewed changes
AlexanderSehr and others added 3 commits March 5, 2022 22:34
@AlexanderSehr
Update arm/Microsoft.Network/vpnSites/.parameters/parameters.json
4814c3f 
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
@AlexanderSehr
Update arm/Microsoft.Network/virtualHubs/deploy.bicep
7d94743 
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
@AlexanderSehr
Update arm/Microsoft.Network/vpnSites/.parameters/min.parameters.json
3931796 
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
@MariusStorhaug MariusStorhaug merged commit 80287c5 into main Mar 5, 2022
@MariusStorhaug MariusStorhaug deleted the users/alsehr/982_vpnSite branch March 5, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MariusStorhaug MariusStorhaug MariusStorhaug approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@AlexanderSehr AlexanderSehr

Labels

[cat] modules category: modules [cat] testing category: testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

vWAN: Move modules out of vWAN

2 participants

@AlexanderSehr @MariusStorhaug