Skip to content

vWAN: Moved resources to corresponding modules and removed duplicates#1090

Merged
AlexanderSehr merged 9 commits intomainfrom
users/alsehr/982_vWANCleanup
Mar 7, 2022
Merged

vWAN: Moved resources to corresponding modules and removed duplicates#1090
AlexanderSehr merged 9 commits intomainfrom
users/alsehr/982_vWANCleanup

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@AlexanderSehr AlexanderSehr commented Mar 5, 2022 •
edited
Loading

Change

  • Moved resources to corresponding modules and removed duplicates (incl. RBAC)
  • Added new vWAN parameters
  • Added new vWAN parameter file

Pipeline reference
Network: VirtualWans

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

@AlexanderSehr AlexanderSehr self-assigned this Mar 5, 2022
@AlexanderSehr AlexanderSehr added the [cat] modules category: modules label Mar 5, 2022
@AlexanderSehr AlexanderSehr added this to the v 0.5 milestone Mar 5, 2022
@AlexanderSehr AlexanderSehr linked an issue Mar 5, 2022 that may be closed by this pull request
vWAN: Move modules out of vWAN #982
Closed
eriqua
eriqua reviewed Mar 5, 2022
View reviewed changes
eriqua
eriqua reviewed Mar 5, 2022
View reviewed changes
eriqua
eriqua reviewed Mar 5, 2022
View reviewed changes
eriqua
eriqua reviewed Mar 6, 2022
View reviewed changes
AlexanderSehr and others added 4 commits March 6, 2022 07:54
@AlexanderSehr @eriqua
Update arm/Microsoft.Network/virtualWans/deploy.bicep
2cdb518 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update arm/Microsoft.Network/virtualWans/deploy.bicep
ef66514 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr
Update to latest
bd01b85
@AlexanderSehr
Update to latest
32612f2
eriqua
eriqua reviewed Mar 7, 2022
View reviewed changes
eriqua
eriqua approved these changes Mar 7, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 75bfc7e into main Mar 7, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/982_vWANCleanup branch March 7, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels

[cat] modules category: modules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

vWAN: Move modules out of vWAN

2 participants

@AlexanderSehr @eriqua