add Azure Active Directory as sql server admin authentication#1106
Merged
AlexanderSehr merged 10 commits intoAzure:mainfrom Mar 10, 2022
Merged
add Azure Active Directory as sql server admin authentication#1106AlexanderSehr merged 10 commits intoAzure:mainfrom
AlexanderSehr merged 10 commits intoAzure:mainfrom
Conversation
Contributor
|
Hey @mvbugge, thanks for the great contribution. Just a few comments and asks. |
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Contributor
|
I'll give the template a spin as soon as I can. If the change works in the pipeline, we can merge it |
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Contributor
|
Hey @mvbugge , I created a branch with your code to test the changes using pipelines. To make it transparent, I opened a draft PR which is not supposed to be merged. |
Contributor
Author
|
@MrMCake I've added the suggestions to the new PR. I suggest trying |
Contributor
|
@mvbugge You nailed it. I successfully tested it in the test PR. |
AlexanderSehr
approved these changes
Mar 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Add the configuration to use AAD as sql server admin authentication.
SQL admin credentials were previously required parameters, this is changed to conditional as they are no longer necessary if AAD is configured to be only authentication method.
Type of Change
Checklist