Skip to content

[CI Environment] Added role assignment removal to removal logic#1343

Merged
AlexanderSehr merged 1 commit intomainfrom
users/alsehr/803_rbacRemoval
May 3, 2022
Merged

[CI Environment] Added role assignment removal to removal logic#1343
AlexanderSehr merged 1 commit intomainfrom
users/alsehr/803_rbacRemoval

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@AlexanderSehr AlexanderSehr commented Apr 27, 2022

Description

  • Added role assignment removal to removal logic

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
KeyVault: Vaults
Resources: ResourceGroups

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

@AlexanderSehr AlexanderSehr linked an issue Apr 27, 2022 that may be closed by this pull request
@AlexanderSehr AlexanderSehr self-assigned this Apr 27, 2022
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] pipelines category: pipelines labels Apr 27, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 27, 2022

Unit Test Results

  1 files  ±    0  1 suites  ±0   11s ⏱️ -12s
  3 tests  -   11  3 ✔️  - 11    0 💤 ±  0  0 ±0 
34 runs   - 102  3 ✔️  - 11  31 💤  - 91  0 ±0 

Results for commit 94ecff5. ± Comparison against base commit 16e32ab.

This pull request removes 14 and adds 3 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults/accessPolicies] used resource type [vaults/accessPolicies] should use one of the recent API version(s). Currently using [2021-06-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults/keys] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2021-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults/keys] used resource type [vaults/keys] should use one of the recent API version(s). Currently using [2019-09-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults/secrets] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2021-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults/secrets] used resource type [vaults/secrets] should use one of the recent API version(s). Currently using [2019-09-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [diagnosticsettings] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [privateEndpoints/privateDnsZoneGroups] should use one of the recent API version(s). Currently using [2021-02-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [privateEndpoints] should use one of the recent API version(s). Currently using [2021-05-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2021-04-01-preview]
…
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Resources/resourceGroups] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Resources/resourceGroups] used resource type [resourceGroups] should use one of the recent API version(s). Currently using [2019-05-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Resources/resourceGroups] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2021-04-01-preview]

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr enabled auto-merge (squash) April 28, 2022 14:20
Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit ccc58fa into main May 3, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/803_rbacRemoval branch May 3, 2022 15:04
@AlexanderSehr AlexanderSehr changed the title Added role assignment removal to removal logic [CI environment] Added role assignment removal to removal logic Jun 17, 2022
@AlexanderSehr AlexanderSehr changed the title [CI environment] Added role assignment removal to removal logic [CI Environment] Added role assignment removal to removal logic Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] pipelines category: pipelines enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Removal of RoleAssignment does not work with Remove-AzResource

2 participants