Skip to content

[Modules] Added configuration options to Microsoft.Batch/batchAccounts#1348

Merged
AlexanderSehr merged 20 commits intomainfrom
users/fblix_jpeasier/batchUpdates
May 2, 2022
Merged

[Modules] Added configuration options to Microsoft.Batch/batchAccounts#1348
AlexanderSehr merged 20 commits intomainfrom
users/fblix_jpeasier/batchUpdates

Conversation

@fblix
Copy link
Copy Markdown
Contributor

@fblix fblix commented Apr 29, 2022

Description

The current batchaccounts module does not support any detailed configurations towards the Azure resource.
The one @JPEasier and myself added, supports the full range of options currently available from the API directly.

Developed with pair-programming.

Pipeline references

Batch: BatchAccounts

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@fblix
Copy link
Copy Markdown
Contributor Author

fblix commented Apr 29, 2022

waiting for #1350

@eriqua eriqua added enhancement New feature or request [cat] modules category: modules labels Apr 29, 2022
fblix and others added 2 commits April 29, 2022 18:43
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Felix Borst and others added 3 commits April 29, 2022 18:50
@JPEasier
Copy link
Copy Markdown
Contributor

Waiting for Bug: #1347

@AlexanderSehr
Copy link
Copy Markdown
Contributor

Waiting for Bug: #1347

As per the reply in the other PR - Linter should not block this PR as it is overly sensitive

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 2, 2022

Unit Test Results

  1 files  1 suites   10s ⏱️
  3 tests 3 ✔️   0 💤 0
35 runs  3 ✔️ 32 💤 0

Results for commit 7a68863.

♻️ This comment has been updated with latest results.

@fblix fblix requested a review from eriqua May 2, 2022 11:50
@fblix
Copy link
Copy Markdown
Contributor Author

fblix commented May 2, 2022

Waiting for Bug: #1347

As per the reply in the other PR - Linter should not block this PR as it is overly sensitive

gotcha, thought the linter had to be green in order to merge it. Will proceed as soon as @eriqua gives her go :)

@AlexanderSehr AlexanderSehr merged commit b592eb3 into main May 2, 2022
@AlexanderSehr AlexanderSehr deleted the users/fblix_jpeasier/batchUpdates branch May 2, 2022 20:16
@AlexanderSehr AlexanderSehr changed the title Added configuration options to Microsoft.Batch/batchAccounts [Modules] Added configuration options to Microsoft.Batch/batchAccounts Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants