Skip to content

[Modules] Added location output to templates#1371

Merged
AlexanderSehr merged 8 commits intomainfrom
users/alsehr/1010_locationOutput
May 11, 2022
Merged

[Modules] Added location output to templates#1371
AlexanderSehr merged 8 commits intomainfrom
users/alsehr/1010_locationOutput

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@AlexanderSehr AlexanderSehr commented May 7, 2022 •
edited
Loading

Description

  • Added location output to templates (for those where the primary resource that support it)
  • Added test case for location output
  • Split original outputs tests into separate test cases
  • Improved function import for tests

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
AnalysisServices: Servers
Resources: ResourceGroups
Authorization: PolicyAssignments
Authorization: RoleAssignments

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

@AlexanderSehr AlexanderSehr linked an issue May 7, 2022 that may be closed by this pull request
Add location to outputs on all modules which support it #1010
Closed
@AlexanderSehr AlexanderSehr self-assigned this May 7, 2022
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules [cat] testing category: testing labels May 7, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 7, 2022 •
edited
Loading

Unit Test Results

1 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit 41e92f3.

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr enabled auto-merge (squash) May 7, 2022 23:14
@eriqua eriqua changed the title Added location output to templates [Modules] Added location output to templates May 8, 2022
eriqua
eriqua reviewed May 11, 2022
View reviewed changes
eriqua
eriqua requested changes May 11, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update wiki pages:

Module design>Outputs section
(if useful) Static validation currently just saying "the minimum set of outputs is returned"

AlexanderSehr and others added 2 commits May 11, 2022 20:48
@AlexanderSehr @eriqua
Update arm/Microsoft.ContainerService/managedClusters/readme.md
99fb7a5 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr
Updated readme
c307df4
@AlexanderSehr
Copy link
Copy Markdown
Contributor Author

AlexanderSehr commented May 11, 2022

Please update wiki pages:

Module design>Outputs section (if useful) Static validation currently just saying "the minimum set of outputs is returned"

Good catch. Updated

@AlexanderSehr AlexanderSehr requested a review from eriqua May 11, 2022 18:54
eriqua
eriqua approved these changes May 11, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit f934cba into main May 11, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1010_locationOutput branch May 11, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels

[cat] modules category: modules [cat] testing category: testing enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add location to outputs on all modules which support it

2 participants

@AlexanderSehr @eriqua