Skip to content

[Modules] Fixed Inconsistent naming of NSGs IDs #1323#1406

Merged
prasanjeets merged 1 commit intomainfrom
users/prsaha/nsgidfix
May 19, 2022
Merged

[Modules] Fixed Inconsistent naming of NSGs IDs #1323#1406
prasanjeets merged 1 commit intomainfrom
users/prsaha/nsgidfix

Conversation

@prasanjeets
Copy link
Copy Markdown
Contributor

Inconsistent naming of NSGs IDs in compute/virtualmachines #1323

Thank you for your contribution !

NSG parameter is not updated asper the standard, so updated the currect parameter "networkSecurityGroupId" and also conducted the test against the same

@prasanjeets prasanjeets requested a review from rahalan May 18, 2022 08:29
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels May 18, 2022
@AlexanderSehr AlexanderSehr changed the title Fixed Inconsistent naming of NSGs IDs #1323 [Module] Fixed Inconsistent naming of NSGs IDs #1323 May 18, 2022
@prasanjeets prasanjeets merged commit 4473142 into main May 19, 2022
@prasanjeets prasanjeets deleted the users/prsaha/nsgidfix branch May 19, 2022 04:52
AlexanderSehr added a commit that referenced this pull request May 19, 2022
* Fixed Inconsistent naming of NSGs IDs #1323 (#1406)

* Added telemetry to AAD module & description to docs (#1393)

* Added telemetry to AAD module & description to docs

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Fixed several minor complains

* Added condition

Co-authored-by: prasanjeets <91326088+prasanjeets@users.noreply.github.com>
jontreynes pushed a commit that referenced this pull request May 23, 2022
* Fixed Inconsistent naming of NSGs IDs #1323 (#1406)

* Added telemetry to AAD module & description to docs (#1393)

* Added telemetry to AAD module & description to docs

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Fixed several minor complains

* Added condition

Co-authored-by: prasanjeets <91326088+prasanjeets@users.noreply.github.com>
@AlexanderSehr AlexanderSehr changed the title [Module] Fixed Inconsistent naming of NSGs IDs #1323 [Modules] Fixed Inconsistent naming of NSGs IDs #1323 Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants