[Modules] Service bus private networking ACL#1453
Merged
MariusStorhaug merged 41 commits intoAzure:mainfrom Jul 7, 2022
Merged
[Modules] Service bus private networking ACL#1453MariusStorhaug merged 41 commits intoAzure:mainfrom
MariusStorhaug merged 41 commits intoAzure:mainfrom
Conversation
AlexanderSehr
added
enhancement
eriqua
changed the title
eriqua
reviewed
Jun 1, 2022
eriqua
reviewed
Jun 1, 2022
eriqua
reviewed
Jun 1, 2022
eriqua
reviewed
Jun 1, 2022
arm/Microsoft.ServiceBus/namespaces/networkRuleSets/deploy.bicep
Outdated
Show resolved
Hide resolved
eriqua
reviewed
Jun 1, 2022
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Trusted Services set default is true
MariusStorhaug
previously requested changes
Jun 3, 2022
arm/Microsoft.ServiceBus/namespaces/networkRuleSets/deploy.bicep
Outdated
Show resolved
Hide resolved
arm/Microsoft.ServiceBus/namespaces/networkRuleSets/deploy.bicep
Outdated
Show resolved
Hide resolved
arm/Microsoft.ServiceBus/namespaces/networkRuleSets/deploy.bicep
Outdated
Show resolved
Hide resolved
eriqua
reviewed
Jun 3, 2022
eriqua
reviewed
Jun 3, 2022
arm/Microsoft.ServiceBus/namespaces/.parameters/parameters.json
Outdated
Show resolved
Hide resolved
NetworkACL => NetworkRuleSet Version Change Co-authored-by: Marius Storhaug <marstor@hotmail.com>
eriqua
reviewed
Jun 6, 2022
Contributor
eriqua
left a comment
eriqua
left a comment
There was a problem hiding this comment.
Further team discussion needed to align on the implementation as this fits into a wider topic (ref issue #819)
Friendly name of resource change to match resource type Co-authored-by: Marius Storhaug <marstor@hotmail.com>
Removed TODO's Co-authored-by: Marius Storhaug <marstor@hotmail.com>
eriqua
reviewed
Jun 14, 2022
arm/Microsoft.ServiceBus/namespaces/networkRuleSets/deploy.bicep
Outdated
Show resolved
Hide resolved
eriqua
reviewed
Jun 14, 2022
15 tasks
4 tasks
Committed in error merging latest changes from Azure:/main
eriqua
reviewed
Jul 6, 2022
eriqua
reviewed
Jul 6, 2022
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
params set as defaults in code Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
eriqua
reviewed
Jul 6, 2022
eriqua
reviewed
Jul 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Private Networking for Azure Service Bus
Adding of the networkRuleSets Module to allow network configurations to be dynamically created for Azure Service Bus based on SKU and Private Endpoint
Pipeline references
https://github.com/ChrisSidebotham/ResourceModules/actions/runs/2410217790
Type of Change
Please delete options that are not relevant.
Checklist