Skip to content

[Modules] Congnitive Services: Set secure defaults#1483

Merged
AlexanderSehr merged 35 commits intomainfrom
users/alsehr/776_cogSerCMK
Jun 22, 2022
Merged

[Modules] Congnitive Services: Set secure defaults#1483
AlexanderSehr merged 35 commits intomainfrom
users/alsehr/776_cogSerCMK

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@AlexanderSehr AlexanderSehr commented Jun 5, 2022 •
edited
Loading

Description

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
CognitiveServices: Accounts

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Jun 5, 2022
@AlexanderSehr AlexanderSehr linked an issue Jun 5, 2022 that may be closed by this pull request
Set default values to a secure value - Cognitive Services #776
Closed
5 tasks
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Jun 5, 2022
@AlexanderSehr AlexanderSehr marked this pull request as draft June 5, 2022 15:10
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 5, 2022 •
edited
Loading

Unit Test Results

  1 files    1 suites   18s ⏱️
60 tests 60 ✔️ 0 💤 0 ❌
63 runs  63 ✔️ 0 💤 0 ❌

Results for commit 3fcf964.

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr marked this pull request as ready for review June 5, 2022 17:27
eriqua
eriqua reviewed Jun 6, 2022
View reviewed changes
eriqua
eriqua reviewed Jun 6, 2022
View reviewed changes
eriqua
eriqua reviewed Jun 6, 2022
View reviewed changes
@AlexanderSehr @eriqua
Update arm/Microsoft.CognitiveServices/accounts/readme.md
4577734 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@eriqua eriqua marked this pull request as draft June 7, 2022 16:48
@AlexanderSehr AlexanderSehr marked this pull request as ready for review June 7, 2022 18:46
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) June 8, 2022 05:21
@AlexanderSehr AlexanderSehr requested a review from eriqua June 8, 2022 17:37
eriqua
eriqua reviewed Jun 9, 2022
View reviewed changes
@AlexanderSehr AlexanderSehr requested a review from eriqua June 10, 2022 10:22
eriqua
eriqua reviewed Jun 14, 2022
View reviewed changes
@eriqua eriqua mentioned this pull request Jun 15, 2022
Closed
15 tasks
@AlexanderSehr AlexanderSehr requested a review from eriqua June 16, 2022 21:31
eriqua
eriqua approved these changes Jun 22, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 0afd825 into main Jun 22, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/776_cogSerCMK branch June 22, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels

[cat] modules category: modules enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Set default values to a secure value - Cognitive Services

2 participants

@AlexanderSehr @eriqua