Skip to content

[Modules] Lock module and cross reference from RG#1547

Merged
eriqua merged 59 commits intoAzure:mainfrom
eriqua:main
Jun 20, 2022
Merged

[Modules] Lock module and cross reference from RG#1547
eriqua merged 59 commits intoAzure:mainfrom
eriqua:main

Conversation

@eriqua
Copy link
Copy Markdown
Contributor

@eriqua eriqua commented Jun 17, 2022

Description

  • Creating a new module for Authorization Locks (rg + subscription scope)
  • Enabling testing the module at resource group scope. Currently it's not possible to continuously test on subscription scope, thus the code for the subscription part has been tested manually.
  • Cross referencing locks from the Resource Group module
  • Removing nested locks module from resource group
  • Adding new RG resource to dependencies pipeline to which testing locks (we don't want the cannot delete lock on the validation-rg meanwhile potentially all module pipelines run in parallel)

    Note Wiki update for additional dependency will be suggested directly in the Wiki review PR to avoid merge conflicts

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Authorization: Locks
Resources: ResourceGroups

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua self-assigned this Jun 17, 2022
@eriqua eriqua added enhancement New feature or request [cat] modules category: modules labels Jun 17, 2022
@eriqua eriqua marked this pull request as ready for review June 17, 2022 15:52
@eriqua eriqua marked this pull request as draft June 17, 2022 17:37
@eriqua eriqua marked this pull request as ready for review June 17, 2022 18:14
@eriqua eriqua enabled auto-merge (squash) June 17, 2022 18:14
@eriqua eriqua merged commit f1f6319 into Azure:main Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants