Skip to content

[Modules] MongoDB: Removed throughput if database is deployed serverless#1571

Merged
AlexanderSehr merged 2 commits intoAzure:users/itpropro/fixMongofrom
itpropro:fix/mongo
Jun 25, 2022
Merged

[Modules] MongoDB: Removed throughput if database is deployed serverless#1571
AlexanderSehr merged 2 commits intoAzure:users/itpropro/fixMongofrom
itpropro:fix/mongo

Conversation

@itpropro
Copy link
Copy Markdown
Contributor

@itpropro itpropro commented Jun 21, 2022

Description

Replaced thoughput parameter with null, if the database capabilities contain EnableServerless.

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Jun 22, 2022
@AlexanderSehr AlexanderSehr changed the title fix(mongodb): Removed throughput if database is deployed serverless [Modules] MongoDB: Removed throughput if database is deployed serverless Jun 22, 2022
@itpropro
Copy link
Copy Markdown
Contributor Author

itpropro commented Jun 23, 2022

Is there anything I need to contribute to close this PR @MrMCake ?

@AlexanderSehr
Copy link
Copy Markdown
Contributor

AlexanderSehr commented Jun 25, 2022

Is there anything I need to contribute to close this PR @MrMCake ?

A badge, like for the others ;) Preparing a merge branch now

@AlexanderSehr AlexanderSehr changed the base branch from main to users/itpropro/fixMongo June 25, 2022 17:11
@AlexanderSehr AlexanderSehr merged commit cbbffbb into Azure:users/itpropro/fixMongo Jun 25, 2022
@AlexanderSehr AlexanderSehr mentioned this pull request Jun 25, 2022
Merged
4 tasks
AlexanderSehr added a commit that referenced this pull request Jun 27, 2022
@AlexanderSehr @itpropro
[Modules] MongoDB: Removed throughput if database is deployed serverl…
d69070b 
…ess (#1571) (#1594)

* fix(mongodb):  Removed throughput if database is deployed serverless

* fix(mongodb):  Added thoughput ternary to collections

Co-authored-by: Jan-Henrik Damaschke <jdamaschke@visorian.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@itpropro itpropro

Labels

[cat] modules category: modules enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@itpropro @AlexanderSehr