[Modules] Recovery Services Vault: Updated API and added new feature properties#1572

Merged

AlexanderSehr merged 12 commits intomainfrom

users/prsaha/apifixrsv_updated#1388

Jul 13, 2022

Contributor

prasanjeets commented Jun 22, 2022 •

edited

Loading

Description

updated all changes in one PR ([Modules] Changed to updated API and also added new feature properties #1490)

Pipeline references

Pipeline

Type of Change

Please delete options that are not relevant.

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Update to documentation

Checklist

I'm sure there are no other open Pull Requests for the same update/change
My corresponding pipelines / checks run clean and green without any errors or warnings
My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation (readme)
I did format my code


          updated all changes in one PR

92f6930

prasanjeets requested review from AlexanderSehr and eriqua

June 22, 2022 05:54

prasanjeets added 2 commits

June 22, 2022 11:28


          principalType: !empty(principalType) ? any(principalType) : null

5b54d2d


          added lock in param

1679f42

AlexanderSehr assigned prasanjeets

AlexanderSehr added the [cat] modules label

AlexanderSehr reviewed

View reviewed changes

arm/Microsoft.RecoveryServices/vaults/protectionContainers/deploy.bicep Show resolved Hide resolved

AlexanderSehr reviewed

View reviewed changes

arm/Microsoft.RecoveryServices/vaults/protectionContainers/protectedItems/deploy.bicep Show resolved Hide resolved

AlexanderSehr reviewed

View reviewed changes

arm/Microsoft.RecoveryServices/vaults/protectionContainers/protectedItems/deploy.bicep Show resolved Hide resolved

AlexanderSehr reviewed

View reviewed changes

arm/Microsoft.RecoveryServices/vaults/protectionContainers/protectedItems/deploy.bicep Show resolved Hide resolved

AlexanderSehr reviewed

View reviewed changes

arm/Microsoft.RecoveryServices/vaults/protectionContainers/readme.md Outdated Show resolved Hide resolved

AlexanderSehr reviewed

View reviewed changes

arm/Microsoft.RecoveryServices/vaults/replicationFabrics/deploy.bicep Outdated Show resolved Hide resolved

AlexanderSehr reviewed

View reviewed changes

...soft.RecoveryServices/vaults/replicationFabrics/replicationProtectionContainers/deploy.bicep Outdated Show resolved Hide resolved

AlexanderSehr reviewed

View reviewed changes

...nFabrics/replicationProtectionContainers/replicationProtectionContainerMappings/deploy.bicep Outdated Show resolved Hide resolved


          commit

ec13189

AlexanderSehr added the enhancement label

prasanjeets added 2 commits

June 22, 2022 13:29


          moduleReadMeSource

564fd8a


          Updated BackupConfig

dca5ce3

ghost commented Jun 22, 2022 •

edited by ghost

Loading

All CLA requirements met.


          Updated

18b18d5

prasanjeets changed the title ~~updated all changes in one PR ([Modules] Changed to updated API and also added new feature properties#1490)~~ RSV API Update_[Modules] Changed to updated API and also added new feature properties#1490)

prasanjeets requested a review from AlexanderSehr

June 22, 2022 09:02

AlexanderSehr mentioned this pull request

[Modules] Changed to updated API and also added new feature properties #1490

Closed

10 tasks

AlexanderSehr changed the title ~~RSV API Update_[Modules] Changed to updated API and also added new feature properties#1490)~~ [Modules] RSV: Updated API and added new feature properties


          Merge branch 'main' of https://github.com/Azure/ResourceModules into …

4f1b1f3

…users/prsaha/apifixrsv_updated#1388

prasanjeets requested a review from a team as a code owner

July 8, 2022 12:42

prasanjeets changed the title ~~[Modules] RSV: Updated API and added new feature properties~~ [Modules] Recovery Services Vault: Updated API and added new feature properties

eriqua reviewed

View reviewed changes

...soft.RecoveryServices/vaults/replicationFabrics/replicationProtectionContainers/deploy.bicep Outdated Show resolved Hide resolved

eriqua reviewed

View reviewed changes

...soft.RecoveryServices/vaults/replicationFabrics/replicationProtectionContainers/deploy.bicep Outdated Show resolved Hide resolved

eriqua reviewed

View reviewed changes

modules/Microsoft.RecoveryServices/vaults/replicationFabrics/deploy.bicep Outdated Show resolved Hide resolved

eriqua reviewed

View reviewed changes

modules/Microsoft.RecoveryServices/vaults/replicationFabrics/deploy.bicep Outdated Show resolved Hide resolved

prasanjeets added 2 commits

July 11, 2022 15:02


          Updated_Readme

e5ee7c2


          commit

f319c70

prasanjeets requested a review from eriqua

July 11, 2022 14:16

prasanjeets added 2 commits

July 11, 2022 19:53


          Merge branch 'main' of https://github.com/Azure/ResourceModules into …

10b62b9

…users/prsaha/apifixrsv_updated#1388


          Merge branch 'main' of https://github.com/Azure/ResourceModules into …

bac1455

…users/prsaha/apifixrsv_updated#1388

AlexanderSehr approved these changes

View reviewed changes

AlexanderSehr enabled auto-merge (squash)

July 13, 2022 17:23

AlexanderSehr merged commit be70744 into main

AlexanderSehr deleted the users/prsaha/apifixrsv_updated#1388 branch

July 13, 2022 17:24

eriqua mentioned this pull request

[Feature Request]: API versions for Recovery Services Vaults and related resources are outdated #1388

Closed

AlexanderSehr linked an issue

that may be closed by this pull request

[Feature Request]: API versions for Recovery Services Vaults and related resources are outdated #1388

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules enhancement