Skip to content

[Modules] MachineLearningWorkspace: Updated Customer-Managed-Key implementation#1584

Merged
AlexanderSehr merged 13 commits intomainfrom
users/alsehr/786_mlCMK
Jul 6, 2022
Merged

[Modules] MachineLearningWorkspace: Updated Customer-Managed-Key implementation#1584
AlexanderSehr merged 13 commits intomainfrom
users/alsehr/786_mlCMK

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@AlexanderSehr AlexanderSehr commented Jun 24, 2022

Description

  • Updated CMK implementation to common pattern
  • This also allows us to avoid the need for specifying a particular key version in the parameter file

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
MachineLearningServices: Workspaces

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Jun 24, 2022
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Jun 24, 2022
@AlexanderSehr AlexanderSehr linked an issue Jun 24, 2022 that may be closed by this pull request
Set default values to a secure value - Machine Learning Workspaces #786
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 24, 2022 •
edited
Loading

Unit Test Results

  1 files  ±    0    1 suites  ±0   23s ⏱️ -33s
79 tests  - 284  79 ✔️  - 274  0 💤  - 10  0 ❌ ±0 
81 runs   - 284  81 ✔️  - 274  0 💤  - 10  0 ❌ ±0 

Results for commit 0805157. ± Comparison against base commit f7eabf6.

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr marked this pull request as draft June 24, 2022 07:00
@AlexanderSehr AlexanderSehr marked this pull request as ready for review June 24, 2022 09:15
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) June 24, 2022 09:15
@AlexanderSehr AlexanderSehr changed the title Updated cmk implementation [Modules] MachineLearningWorkspace: Updated Customer-Managed-Key implementation Jun 24, 2022
@AlexanderSehr AlexanderSehr marked this pull request as draft June 24, 2022 22:11
auto-merge was automatically disabled June 24, 2022 22:11

Pull request was converted to draft

@AlexanderSehr AlexanderSehr marked this pull request as ready for review June 24, 2022 22:17
@AlexanderSehr AlexanderSehr marked this pull request as draft June 27, 2022 15:50
@AlexanderSehr AlexanderSehr marked this pull request as ready for review June 28, 2022 05:30
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner June 28, 2022 05:30
@kavishshivhare kavishshivhare mentioned this pull request Jun 29, 2022
Closed
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) July 6, 2022 16:28
eriqua
eriqua approved these changes Jul 6, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 80c29bd into main Jul 6, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/786_mlCMK branch July 6, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels

[cat] modules category: modules enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Set default values to a secure value - Machine Learning Workspaces

2 participants

@AlexanderSehr @eriqua