Skip to content

[Fixes] Role Assignment output #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahmadabdalla merged 5 commits into from
Jul 7, 2022
Merged

[Fixes] Role Assignment output #1649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dc21bc9
mg
eriqua Jul 7, 2022
9953c9f
rg
eriqua Jul 7, 2022
146c343
sub
eriqua Jul 7, 2022
8a6c7d9
roledef
eriqua Jul 7, 2022
93e0c63
readme update
eriqua Jul 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/Microsoft.Authorization/roleAssignments/managementGroup/deploy.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ resource roleAssignment 'Microsoft.Authorization/roleAssignments@2020-10-01-prev
output name string = roleAssignment.name

@sys.description('The resource ID of the Role Assignment.')
output scope string = tenantResourceId('Microsoft.Management/managementGroups', managementGroupId)
output resourceId string = extensionResourceId(tenantResourceId('Microsoft.Management/managementGroups', managementGroupId), 'Microsoft.Authorization/roleAssignments', roleAssignment.name)

@sys.description('The scope this Role Assignment applies to.')
output resourceId string = extensionResourceId(tenantResourceId('Microsoft.Management/managementGroups', managementGroupId), 'Microsoft.Authorization/roleAssignments', roleAssignment.name)
output scope string = tenantResourceId('Microsoft.Management/managementGroups', managementGroupId)
4 changes: 2 additions & 2 deletions modules/Microsoft.Authorization/roleAssignments/managementGroup/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,5 @@ With this module you can perform role assignments on a management group level
| Output Name | Type | Description |
| :-- | :-- | :-- |
| `name` | string | The GUID of the Role Assignment. |
| `resourceId` | string | The scope this Role Assignment applies to. |
| `scope` | string | The resource ID of the Role Assignment. |
| `resourceId` | string | The resource ID of the Role Assignment. |
| `scope` | string | The scope this Role Assignment applies to. |
6 changes: 3 additions & 3 deletions modules/Microsoft.Authorization/roleAssignments/resourceGroup/deploy.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,10 +356,10 @@ resource roleAssignment 'Microsoft.Authorization/roleAssignments@2020-10-01-prev
output name string = roleAssignment.name

@sys.description('The resource ID of the Role Assignment.')
output scope string = resourceGroup().id

@sys.description('The scope this Role Assignment applies to.')
output resourceId string = az.resourceId(resourceGroupName, 'Microsoft.Authorization/roleAssignments', roleAssignment.name)

@sys.description('The name of the resource group the role assignment was applied at.')
output resourceGroupName string = resourceGroup().name

@sys.description('The scope this Role Assignment applies to.')
output scope string = resourceGroup().id
4 changes: 2 additions & 2 deletions modules/Microsoft.Authorization/roleAssignments/resourceGroup/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,5 @@ With this module you can perform role assignments on a resource group level
| :-- | :-- | :-- |
| `name` | string | The GUID of the Role Assignment. |
| `resourceGroupName` | string | The name of the resource group the role assignment was applied at. |
| `resourceId` | string | The scope this Role Assignment applies to. |
| `scope` | string | The resource ID of the Role Assignment. |
| `resourceId` | string | The resource ID of the Role Assignment. |
| `scope` | string | The scope this Role Assignment applies to. |
4 changes: 2 additions & 2 deletions modules/Microsoft.Authorization/roleAssignments/subscription/deploy.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ resource roleAssignment 'Microsoft.Authorization/roleAssignments@2020-10-01-prev
output name string = roleAssignment.name

@sys.description('The resource ID of the Role Assignment.')
output scope string = subscription().id
output resourceId string = subscriptionResourceId(subscriptionId, 'Microsoft.Authorization/roleAssignments', roleAssignment.name)

@sys.description('The scope this Role Assignment applies to.')
output resourceId string = subscriptionResourceId(subscriptionId, 'Microsoft.Authorization/roleAssignments', roleAssignment.name)
output scope string = subscription().id
4 changes: 2 additions & 2 deletions modules/Microsoft.Authorization/roleAssignments/subscription/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,5 @@ With this module you can perform role assignments on a subscription level
| Output Name | Type | Description |
| :-- | :-- | :-- |
| `name` | string | The GUID of the Role Assignment. |
| `resourceId` | string | The scope this Role Assignment applies to. |
| `scope` | string | The resource ID of the Role Assignment. |
| `resourceId` | string | The resource ID of the Role Assignment. |
| `scope` | string | The scope this Role Assignment applies to. |
2 changes: 1 addition & 1 deletion modules/Microsoft.Authorization/roleDefinitions/deploy.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,4 +107,4 @@ output name string = empty(subscriptionId) && empty(resourceGroupName) ? roleDef
output resourceId string = empty(subscriptionId) && empty(resourceGroupName) ? roleDefinition_mg.outputs.resourceId : (!empty(subscriptionId) && empty(resourceGroupName) ? roleDefinition_sub.outputs.resourceId : roleDefinition_rg.outputs.resourceId)

@sys.description('The scope this Role Definition applies to.')
output roleDefinitionScope string = empty(subscriptionId) && empty(resourceGroupName) ? roleDefinition_mg.outputs.scope : (!empty(subscriptionId) && empty(resourceGroupName) ? roleDefinition_sub.outputs.scope : roleDefinition_rg.outputs.scope)
output scope string = empty(subscriptionId) && empty(resourceGroupName) ? roleDefinition_mg.outputs.scope : (!empty(subscriptionId) && empty(resourceGroupName) ? roleDefinition_sub.outputs.scope : roleDefinition_rg.outputs.scope)
2 changes: 1 addition & 1 deletion modules/Microsoft.Authorization/roleDefinitions/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ module roledefinition 'yourpath/modules/Microsoft.Authorization.roleDefinitions/
| :-- | :-- | :-- |
| `name` | string | The GUID of the Role Definition. |
| `resourceId` | string | The resource ID of the Role Definition. |
| `roleDefinitionScope` | string | The scope this Role Definition applies to. |
| `scope` | string | The scope this Role Definition applies to. |

## Considerations

Expand Down