[Modules] Multi additions to staticSites#1655
Merged
AlexanderSehr merged 8 commits intoAzure:users/itpropro/staticSitesfrom Jul 12, 2022
Merged
[Modules] Multi additions to staticSites#1655AlexanderSehr merged 8 commits intoAzure:users/itpropro/staticSitesfrom
AlexanderSehr merged 8 commits intoAzure:users/itpropro/staticSitesfrom
Conversation
eriqua
reviewed
Jul 10, 2022
modules/Microsoft.Web/staticSites/.bicep/nested_roleAssignments.bicep
Outdated
Show resolved
Hide resolved
eriqua
reviewed
Jul 10, 2022
eriqua
reviewed
Jul 10, 2022
eriqua
reviewed
Jul 10, 2022
eriqua
reviewed
Jul 10, 2022
6 tasks
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Contributor
Author
|
PR feedback integrated, thx @eriqua and @MrMCake! |
AlexanderSehr
approved these changes
Jul 12, 2022
Contributor
AlexanderSehr
left a comment
AlexanderSehr
left a comment
There was a problem hiding this comment.
Approved with merge to branch users/itpropro/staticSites for pipeline validation
4 tasks
AlexanderSehr
added a commit
that referenced
this pull request
Oct 4, 2022
* First commit * [Modules] Multi additions to staticSites (#1655) * feat(staticsites): Added linkedBackends to staticSites extension * feat(staticsites): Added tests, readme, linkedBackends * docs(staticsites): Removed parameter placeholder * Update modules/Microsoft.Web/staticSites/config/readme.md Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * Update modules/Microsoft.Web/staticSites/config/readme.md Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * Update modules/Microsoft.Web/staticSites/customDomains/readme.md Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * Update modules/Microsoft.Web/staticSites/linkedBackends/readme.md Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * fix(staticsites): Integrated PR feedback Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * Update to latest * Updated docs * Updated telemetry & docs * Minor fix * Regenerated main readme * Another try * Updated files on linux * Removed custom domain test as it is not operational * Updated docs * Updated test Co-authored-by: Jan-Henrik Damaschke <jdamaschke@visorian.com> Co-authored-by: Alexander Sehr <alsehr@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added the following to staticSites
config(app config and function app config)customDomainswith different validations depending on apex or notlinkedBackendswith the 2022-03-01 API to add custom function apps. TheuserDefinedFunctionsendpoint should not be used and is currently broken.Changes were verified, pester and deployment tested with the respective PowerShell functions. Readme and parameter files have been updated.
Pipeline references
No pipeline changes
Type of Change
Please delete options that are not relevant.
Checklist