Skip to content

[Modules] Align public network access implementation across modules#1661

Merged
eriqua merged 11 commits intomainfrom
users/erikag/publicNetworkAccess
Jul 12, 2022
Merged

[Modules] Align public network access implementation across modules#1661
eriqua merged 11 commits intomainfrom
users/erikag/publicNetworkAccess

Conversation

@eriqua
Copy link
Copy Markdown
Contributor

@eriqua eriqua commented Jul 10, 2022

Description

Closes #1660

Aligned public network access implementation across modules besides Compute Disks and Event Hubs which needs to be looked into more thoroughly.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
AppConfiguration: ConfigurationStores
Batch: BatchAccounts
ContainerRegistry: Registries
DataFactory: Factories
EventGrid: Topics
KeyVault: Vaults
MachineLearningServices: Workspaces
ServiceBus: Namespaces
Storage: StorageAccounts

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua added enhancement New feature or request [cat] modules category: modules labels Jul 10, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 11, 2022

Unit Test Results

    1 files  ±    0      1 suites  ±0   34s ⏱️ - 1m 3s
151 tests  - 384  149 ✔️  - 377  2 💤  - 7  0 ±0 
152 runs   - 385  150 ✔️  - 378  2 💤  - 7  0 ±0 

Results for commit 7fd820e. ± Comparison against base commit 2373c29.

♻️ This comment has been updated with latest results.

@eriqua eriqua marked this pull request as ready for review July 12, 2022 15:12
@eriqua eriqua requested a review from a team as a code owner July 12, 2022 15:12
@eriqua eriqua enabled auto-merge (squash) July 12, 2022 15:20
@eriqua eriqua merged commit 3dab249 into main Jul 12, 2022
@eriqua eriqua deleted the users/erikag/publicNetworkAccess branch July 12, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Disable public network access if PE is enabled unless explicitly enabled

2 participants