Skip to content

[CI Environment] Refactored pipelines#1694

Merged
AlexanderSehr merged 11 commits intomainfrom
users/alsehr/pipelineReworkWithoutDependencies
Jul 23, 2022
Merged

[CI Environment] Refactored pipelines#1694
AlexanderSehr merged 11 commits intomainfrom
users/alsehr/pipelineReworkWithoutDependencies

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@AlexanderSehr AlexanderSehr commented Jul 18, 2022

Description

  • Refactored pipelines
    • Enabled parameter file fetch for ADO
    • Removed deployment blocks from ADO (hence added an additional template for the dependency pipeline)
    • Updated GH naming to not reference 'parameter files' (excluding the dependency pipeline) and align with ADO pipelines
    • Some minor improvments that are part of several other smaller PRs and will disappear once they are merged to main

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

GitHub Azure DevOps
AnalysisServices: Servers Build Status
.Platform: Dependencies (unrelated) Build Status (template confirmed)

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner July 18, 2022 15:39
@AlexanderSehr AlexanderSehr marked this pull request as draft July 18, 2022 15:39
@AlexanderSehr AlexanderSehr self-assigned this Jul 18, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 18, 2022

Unit Test Results

  1 files  ±  0    1 suites  ±0   16s ⏱️ -5s
42 tests  - 37  42 ✔️  - 36  0 💤  - 1  0 ±0 
44 runs   - 36  44 ✔️  - 35  0 💤  - 1  0 ±0 

Results for commit 785b359. ± Comparison against base commit 38534b3.

This pull request removes 79 and adds 42 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AppConfiguration/configurationStores/keyValues] used resource type [configurationStores/keyValues] should use one of the recent API version(s). Currently using [2021-10-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AppConfiguration/configurationStores] used resource type [configurationStores/keyValues] should use one of the recent API version(s). Currently using [2021-10-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AppConfiguration/configurationStores] used resource type [configurationStores] should use one of the recent API version(s). Currently using [2021-10-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AppConfiguration/configurationStores] used resource type [diagnosticsettings] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AppConfiguration/configurationStores] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AppConfiguration/configurationStores] used resource type [privateEndpoints/privateDnsZoneGroups] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AppConfiguration/configurationStores] used resource type [privateEndpoints] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AppConfiguration/configurationStores] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2020-10-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.AppConfiguration/configurationStores/keyValues] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.AppConfiguration/configurationStores/keyValues] All parameters in parameters files exist in template file (deploy.json)
…
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AnalysisServices/servers] used resource type [diagnosticsettings] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AnalysisServices/servers] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AnalysisServices/servers] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2020-10-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AnalysisServices/servers] used resource type [servers] should use one of the recent API version(s). Currently using [2017-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.AnalysisServices/servers] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.AnalysisServices/servers] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.AnalysisServices/servers] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.AnalysisServices/servers] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.AnalysisServices/servers] Conditional parameters' description should contain 'Required if' followed by the condition making the parameter required.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.AnalysisServices/servers] If delete lock is implemented, the template should have a lock parameter with the default value of ['']
…

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr added [cat] pipelines category: pipelines [cat] github category: GitHub [cat] azure devops category: Azure DevOps labels Jul 18, 2022
Copy link
Copy Markdown
Contributor

@segraef segraef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice and clean

@AlexanderSehr AlexanderSehr merged commit 85b5b82 into main Jul 23, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/pipelineReworkWithoutDependencies branch July 23, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] azure devops category: Azure DevOps [cat] github category: GitHub [cat] pipelines category: pipelines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants