[Modules] Updated Authorization/policyDefinitions to new dependency approach#1813
Merged
AlexanderSehr merged 12 commits intomainfrom Oct 24, 2022
Merged
Conversation
AlexanderSehr
added
[cat] modules
Contributor
|
Pending change to the implementation approach: |
Contributor
Author
As per our discussion I'd suggest to push this back as neither the global.module.tests, nor especially the Set-ModuleReadMe function will be able to properly handle this alternative approach. A larger refactoring may be required. |
Contributor
ahmadabdalla
left a comment
ahmadabdalla
left a comment
There was a problem hiding this comment.
Thanks Alex. Minor suggestion on the serviceShort name, and please change the folder name to .common for MG and SUB.
modules/Microsoft.Authorization/policyDefinitions/.test/mg/deploy.test.bicep
Outdated
Show resolved
Hide resolved
modules/Microsoft.Authorization/policyDefinitions/.test/sub/deploy.test.bicep
Outdated
Show resolved
Hide resolved
ahmadabdalla
approved these changes
Oct 24, 2022
AlexanderSehr
deleted the
users/alsehr/1791_Authorization_PolicyDefinitions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pipeline references
Type of Change
Please delete options that are not relevant.