Skip to content

[Modules] Updated Authorization/PolicySetDefinitions to new dependency approach#1815

Merged
AlexanderSehr merged 10 commits intomainfrom
users/alsehr/1791_Authorization_PolicySetDefinitions
Oct 24, 2022
Merged

[Modules] Updated Authorization/PolicySetDefinitions to new dependency approach#1815
AlexanderSehr merged 10 commits intomainfrom
users/alsehr/1791_Authorization_PolicySetDefinitions

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@AlexanderSehr AlexanderSehr commented Aug 30, 2022

Description

  • Updated Authorization/PolicySetDefinitions to new dependency approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Authorization: PolicySetDefinitions

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Aug 30, 2022
@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Aug 30, 2022
@AlexanderSehr AlexanderSehr linked an issue Aug 30, 2022 that may be closed by this pull request
[Feature Request]: Re-work modules to new dependency approach #1791
Closed
@AlexanderSehr AlexanderSehr mentioned this pull request Aug 30, 2022
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 30, 2022 •
edited
Loading

Unit Test Results

    1 files      1 suites   1m 4s ⏱️
119 tests 110 ✔️   9 💤 0 ❌
140 runs  128 ✔️ 12 💤 0 ❌

Results for commit c8d73b0.

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr removed a link to an issue Sep 5, 2022
[Feature Request]: Re-work modules to new dependency approach #1791
Closed
@AlexanderSehr AlexanderSehr linked an issue Sep 5, 2022 that may be closed by this pull request
Update Authorization/policySetDefinitions to new dependencies approach #1912
Closed
@AlexanderSehr AlexanderSehr marked this pull request as ready for review September 19, 2022 18:59
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 19, 2022 18:59
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) September 19, 2022 19:00
@ahmadabdalla ahmadabdalla self-requested a review October 11, 2022 09:33
@ahmadabdalla
Copy link
Copy Markdown
Contributor

ahmadabdalla commented Oct 13, 2022

Pending change to the implementation approach:
MicrosoftTeams-image

@AlexanderSehr
Copy link
Copy Markdown
Contributor Author

AlexanderSehr commented Oct 18, 2022

Pending change to the implementation approach: MicrosoftTeams-image

As per our discussion I'd suggest to push this back as neither the global.module.tests, nor especially the Set-ModuleReadMe function will be able to properly handle this alternative approach. A larger refactoring may be required.

ahmadabdalla
ahmadabdalla reviewed Oct 23, 2022
View reviewed changes
@AlexanderSehr AlexanderSehr merged commit 3a1480f into main Oct 24, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_Authorization_PolicySetDefinitions branch October 24, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahmadabdalla ahmadabdalla ahmadabdalla approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels

[cat] modules category: modules [cat] testing category: testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Authorization/policySetDefinitions to new dependencies approach

2 participants

@AlexanderSehr @ahmadabdalla