Skip to content

[Modules] Updated Authorization/RoleAssignments to new dependency approach#1816

Merged
AlexanderSehr merged 38 commits intomainfrom
users/alsehr/1791_Authorization_RoleAssignments
Oct 24, 2022
Merged

[Modules] Updated Authorization/RoleAssignments to new dependency approach#1816
AlexanderSehr merged 38 commits intomainfrom
users/alsehr/1791_Authorization_RoleAssignments

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

Description

  • Updated Authorization/RoleAssignments to new dependency approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Authorization: RoleAssignments

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 30, 2022

Unit Test Results

    1 files  ±  0      1 suites  ±0   1m 21s ⏱️ -21s
161 tests  -   7  152 ✔️  - 13    9 💤 +  6  0 ±0 
214 runs  +39  200 ✔️ +29  14 💤 +10  0 ±0 

Results for commit 66713cb. ± Comparison against base commit 3b9c64e.

This pull request removes 168 and adds 161 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults/accessPolicies] used resource type [vaults/accessPolicies] should use one of the recent API version(s). Currently using [2021-06-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults/keys] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults/keys] used resource type [vaults/keys] should use one of the recent API version(s). Currently using [2019-09-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults/secrets] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults/secrets] used resource type [vaults/secrets] should use one of the recent API version(s). Currently using [2019-09-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [diagnosticsettings] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [privateEndpoints/privateDnsZoneGroups] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [privateEndpoints] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
…
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Authorization/roleAssignments/managementGroup] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Authorization/roleAssignments/resourceGroup] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Authorization/roleAssignments/subscription] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Authorization/roleAssignments] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Authorization/roleAssignments/managementGroup] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Authorization/roleAssignments/managementGroup] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Authorization/roleAssignments/managementGroup] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Authorization/roleAssignments/managementGroup] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Authorization/roleAssignments/managementGroup] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Authorization/roleAssignments/managementGroup] Conditional parameters' description should contain 'Required if' followed by the condition making the parameter required.
…
This pull request removes 3 skipped tests and adds 9 skipped tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.KeyVault/vaults/keys] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.KeyVault/vaults/secrets] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.KeyVault/vaults] *parameters.json files in the .test folder should be valid json
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Authorization/roleAssignments/managementGroup] Resource ID output should exist
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Authorization/roleAssignments/managementGroup] Resource name output should exist
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Authorization/roleAssignments/resourceGroup] Resource ID output should exist
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Authorization/roleAssignments/resourceGroup] Resource name output should exist
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Authorization/roleAssignments/subscription] Resource ID output should exist
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Authorization/roleAssignments/subscription] Resource name output should exist
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Authorization/roleAssignments] Resource ID output should exist
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Authorization/roleAssignments] Resource name output should exist
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Authorization/roleAssignments] *parameters.json files in the .test folder should be valid json

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr marked this pull request as ready for review September 19, 2022 18:59
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 19, 2022 18:59
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) September 19, 2022 18:59
@ahmadabdalla ahmadabdalla self-requested a review October 11, 2022 09:33
@ahmadabdalla
Copy link
Copy Markdown
Contributor

Pending change to the implementation approach:
MicrosoftTeams-image

@AlexanderSehr
Copy link
Copy Markdown
Contributor Author

Pending change to the implementation approach: MicrosoftTeams-image

As per our discussion I'd suggest to push this back as neither the global.module.tests, nor especially the Set-ModuleReadMe function will be able to properly handle this alternative approach. A larger refactoring may be required.

AlexanderSehr and others added 3 commits October 22, 2022 08:37
…dencies.bicep

Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…nterm.dependencies.bicep

Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…ndencies.bicep

Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
AlexanderSehr and others added 20 commits October 22, 2022 08:38
…ndencies.bicep

Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…dependencies.bicep

Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…m.dependencies.bicep

Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…dependencies.bicep

Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…m.dependencies.bicep

Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…nterm.dependencies.bicep

Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…ependencies.bicep

Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…ependencies.bicep

Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…nterm.dependencies.bicep

Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…nterm.dependencies.bicep

Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…dencies.bicep

Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…m.dependencies.bicep

Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…m.dependencies.bicep

Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…ependencies.bicep

Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…dencies.bicep

Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…dencies.bicep

Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…eploy.test.bicep

Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…y.test.bicep

Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
@AlexanderSehr AlexanderSehr merged commit 4104059 into main Oct 24, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_Authorization_RoleAssignments branch October 24, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules [cat] testing category: testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Authorization/roleAssignments to new dependencies approach

2 participants