[Modules] Updated ContainerRegistry/Registries to new dependency approach#1823
Merged
AlexanderSehr merged 19 commits intomainfrom Oct 4, 2022
Merged
Conversation
AlexanderSehr
added
[cat] modules
eriqua
reviewed
Sep 28, 2022
modules/Microsoft.ContainerRegistry/registries/.test/common/deploy.test.bicep
Outdated
Show resolved
Hide resolved
eriqua
reviewed
Sep 28, 2022
modules/Microsoft.ContainerRegistry/registries/.test/min/deploy.test.bicep
Outdated
Show resolved
Hide resolved
eriqua
reviewed
Sep 28, 2022
modules/Microsoft.ContainerRegistry/registries/.test/encr/deploy.test.bicep
Outdated
Show resolved
Hide resolved
eriqua
requested changes
Sep 29, 2022
Contributor
eriqua
left a comment
eriqua
left a comment
There was a problem hiding this comment.
pe.parameters.json module test is missing conversion and causing the pipeline to fail. It was probably added after the initial conversion was done
…ploy.test.bicep Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…y.test.bicep Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…oy.test.bicep Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
AlexanderSehr
deleted the
users/alsehr/1791_ContainerRegistry_Registries
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pipeline references
Type of Change
Please delete options that are not relevant.