Skip to content

[Modules] Updated Network/VirtualHubs to new dependency approach#1831

Merged
AlexanderSehr merged 15 commits intomainfrom
users/alsehr/1791_Network_VirtualHubs
Sep 29, 2022
Merged

[Modules] Updated Network/VirtualHubs to new dependency approach#1831
AlexanderSehr merged 15 commits intomainfrom
users/alsehr/1791_Network_VirtualHubs

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

Description

  • Updated Network/VirtualHubs to new dependency approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Network: VirtualHubs

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@github-actions
Copy link
Copy Markdown

Unit Test Results

    1 files  ±  0      1 suites  ±0   56s ⏱️ +34s
125 tests +81  122 ✔️ +79  3 💤 +2  0 ±0 
135 runs  +91  131 ✔️ +88  4 💤 +3  0 ±0 

Results for commit a2d9ec4. ± Comparison against base commit 6bb70a5.

This pull request removes 44 and adds 125 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Management/managementGroups] used resource type [managementGroups] should use one of the recent API version(s). Currently using [2021-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Management/managementGroups] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Management/managementGroups] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Management/managementGroups] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Management/managementGroups] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Management/managementGroups] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Management/managementGroups] Conditional parameters' description should contain 'Required if' followed by the condition making the parameter required.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Management/managementGroups] If delete lock is implemented, the template should have a lock parameter with the default value of ['']
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Management/managementGroups] Location output should be returned for resources that use it
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Management/managementGroups] Output names should be camel-cased (no dashes or underscores and must start with lower-case letter)
…
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/virtualHubs/hubRouteTables] used resource type [virtualHubs/hubRouteTables] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/virtualHubs/hubVirtualNetworkConnections] used resource type [virtualHubs/hubVirtualNetworkConnections] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/virtualHubs] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/virtualHubs] used resource type [virtualHubs/hubRouteTables] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/virtualHubs] used resource type [virtualHubs/hubVirtualNetworkConnections] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/virtualHubs] used resource type [virtualHubs] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/virtualHubs/hubRouteTables] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/virtualHubs/hubRouteTables] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/virtualHubs/hubRouteTables] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/virtualHubs/hubRouteTables] All required parameters in template file (deploy.json) should exist in parameters files
…
This pull request removes 1 skipped test and adds 3 skipped tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Management/managementGroups] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/virtualHubs/hubRouteTables] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/virtualHubs/hubVirtualNetworkConnections] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Network/virtualHubs] *parameters.json files in the .test folder should be valid json

@AlexanderSehr AlexanderSehr linked an issue Sep 5, 2022 that may be closed by this pull request
@AlexanderSehr AlexanderSehr marked this pull request as ready for review September 19, 2022 18:01
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 19, 2022 18:01
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) September 19, 2022 18:01
@eriqua eriqua added the [prio] high importance of the issue: high priority label Sep 25, 2022
AlexanderSehr and others added 3 commits September 29, 2022 22:45
…s.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…s.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…icep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 4c26d0a into main Sep 29, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_Network_VirtualHubs branch September 29, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules [cat] testing category: testing [prio] high importance of the issue: high priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Network/virtualHubs to new dependencies approach

2 participants