Skip to content

[Modules] Updated Resources/DeploymentScripts to new dependency approach#1835

Merged
AlexanderSehr merged 15 commits intomainfrom
users/alsehr/1791_Resources_DeploymentScripts
Oct 13, 2022
Merged

[Modules] Updated Resources/DeploymentScripts to new dependency approach#1835
AlexanderSehr merged 15 commits intomainfrom
users/alsehr/1791_Resources_DeploymentScripts

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@AlexanderSehr AlexanderSehr commented Aug 30, 2022

Description

  • Updated Resources/DeploymentScripts to new dependency approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Resources: DeploymentScripts

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Aug 30, 2022
@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Aug 30, 2022
@AlexanderSehr AlexanderSehr mentioned this pull request Aug 30, 2022
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 30, 2022

Unit Test Results

  1 files    1 suites   29s ⏱️
51 tests 50 ✔️ 1 💤 0 ❌
61 runs  59 ✔️ 2 💤 0 ❌

Results for commit 396b75f.

@AlexanderSehr AlexanderSehr linked an issue Sep 5, 2022 that may be closed by this pull request
Update Resources/deploymentScripts to new dependencies approach #1958
Closed
@AlexanderSehr AlexanderSehr marked this pull request as ready for review September 19, 2022 06:41
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 19, 2022 06:41
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) September 19, 2022 06:41
AlexanderSehr and others added 3 commits October 13, 2022 17:14
@AlexanderSehr @eriqua
Update modules/Microsoft.Resources/deploymentScripts/.test/ps/deploy.…
69e51ca 
…test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update modules/Microsoft.Resources/deploymentScripts/.test/cli/deploy…
391bff8 
….test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr
Several small updates
4324a1e
eriqua
eriqua approved these changes Oct 13, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 70c17a0 into main Oct 13, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_Resources_DeploymentScripts branch October 13, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels

[cat] modules category: modules [cat] testing category: testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Resources/deploymentScripts to new dependencies approach

2 participants

@AlexanderSehr @eriqua