Skip to content

[Modules] Updated Compute/VirtualMachineScaleSets to new dependency approach#1865

Merged
AlexanderSehr merged 39 commits intomainfrom
users/alsehr/1791_Compute_virtualMachineScaleSets
Nov 18, 2022
Merged

[Modules] Updated Compute/VirtualMachineScaleSets to new dependency approach#1865
AlexanderSehr merged 39 commits intomainfrom
users/alsehr/1791_Compute_virtualMachineScaleSets

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@AlexanderSehr AlexanderSehr commented Sep 2, 2022

Description

  • Updated Compute/VirtualMachineScaleSets to new dependency approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Compute: VirtualMachineScaleSets
Compute: VirtualMachines

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 2, 2022

Unit Test Results

    1 files  ±  0      1 suites  ±0   1m 4s ⏱️ +38s
  96 tests +42    94 ✔️ +42  2 💤 ±0  0 ±0 
126 runs  +72  121 ✔️ +69  5 💤 +3  0 ±0 

Results for commit 4e7701d. ± Comparison against base commit 8f24a3c.

This pull request removes 54 and adds 96 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/dnsResolvers] used resource type [dnsResolvers/inboundEndpoints] should use one of the recent API version(s). Currently using [2022-07-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/dnsResolvers] used resource type [dnsResolvers/outboundEndpoints] should use one of the recent API version(s). Currently using [2022-07-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/dnsResolvers] used resource type [dnsResolvers] should use one of the recent API version(s). Currently using [2022-07-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/dnsResolvers] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/dnsResolvers] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/dnsResolvers] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/dnsResolvers] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/dnsResolvers] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/dnsResolvers] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/dnsResolvers] CUA ID deployment should be present in the template
…
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachineScaleSets/extensions] used resource type [virtualMachineScaleSets/extensions] should use one of the recent API version(s). Currently using [2021-07-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachineScaleSets] used resource type [diagnosticsettings] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachineScaleSets] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachineScaleSets] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachineScaleSets] used resource type [virtualMachineScaleSets/extensions] should use one of the recent API version(s). Currently using [2021-07-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachineScaleSets] used resource type [virtualMachineScaleSets] should use one of the recent API version(s). Currently using [2022-03-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/virtualMachineScaleSets/extensions] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/virtualMachineScaleSets/extensions] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/virtualMachineScaleSets/extensions] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/virtualMachineScaleSets/extensions] All required parameters in template file (deploy.json) should exist in parameters files
…
This pull request removes 2 skipped tests and adds 2 skipped tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/dnsResolvers] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Network/dnsResolvers] *parameters.json files in the .test folder should be valid json
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/virtualMachineScaleSets/extensions] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Compute/virtualMachineScaleSets] *parameters.json files in the .test folder should be valid json

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr marked this pull request as ready for review September 19, 2022 06:26
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 19, 2022 06:26
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) September 19, 2022 06:26
AlexanderSehr and others added 2 commits November 16, 2022 00:08
…dependencies.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…min/dependencies.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
AlexanderSehr and others added 11 commits November 17, 2022 00:09
…s.min/dependencies.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…s/dependencies.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…s/dependencies.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…dependencies.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 17, 2022

Test Results

    1 files  ±    0      1 suites  ±0   1m 10s ⏱️ - 2m 43s
100 tests  - 474    98 ✔️  - 466  2 💤  - 8  0 ±0 
150 runs   - 441  143 ✔️  - 436  7 💤  - 5  0 ±0 

Results for commit 6f0fd43. ± Comparison against base commit 136b994.

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 677d156 into main Nov 18, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_Compute_virtualMachineScaleSets branch November 18, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules [cat] testing category: testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Compute/virtualMachineScaleSets to new dependencies approach

2 participants