Skip to content

[Modules] Refactored Network Application Gateway to new dependency approach#1871

Merged
AlexanderSehr merged 21 commits intomainfrom
users/alsehr/1791_network_appGw
Oct 11, 2022
Merged

[Modules] Refactored Network Application Gateway to new dependency approach#1871
AlexanderSehr merged 21 commits intomainfrom
users/alsehr/1791_network_appGw

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@AlexanderSehr AlexanderSehr commented Sep 2, 2022

Description

  • Refactored Network Application Gateway to new dependency approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Network: ApplicationGateways

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 2, 2022

Unit Test Results

  1 files  ±  0    1 suites  ±0   39s ⏱️ -7s
56 tests +  1  55 ✔️ +  1  1 💤 ±0  0 ±0 
56 runs   - 26  55 ✔️  - 23  1 💤  - 3  0 ±0 

Results for commit 2cb152c. ± Comparison against base commit f1f0552.

This pull request removes 55 and adds 56 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.CognitiveServices/accounts] used resource type [accounts] should use one of the recent API version(s). Currently using [2021-10-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.CognitiveServices/accounts] used resource type [diagnosticsettings] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.CognitiveServices/accounts] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.CognitiveServices/accounts] used resource type [privateEndpoints/privateDnsZoneGroups] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.CognitiveServices/accounts] used resource type [privateEndpoints] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.CognitiveServices/accounts] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.CognitiveServices/accounts] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.CognitiveServices/accounts] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.CognitiveServices/accounts] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.CognitiveServices/accounts] All required parameters in template file (deploy.json) should exist in parameters files
…
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/applicationGateways] used resource type [applicationGateways] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/applicationGateways] used resource type [diagnosticsettings] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/applicationGateways] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/applicationGateways] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/applicationGateways] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/applicationGateways] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/applicationGateways] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/applicationGateways] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/applicationGateways] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/applicationGateways] Conditional parameters' description should contain 'Required if' followed by the condition making the parameter required.
…
This pull request removes 1 skipped test and adds 1 skipped test. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.CognitiveServices/accounts] *parameters.json files in the .test folder should be valid json
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Network/applicationGateways] *parameters.json files in the .test folder should be valid json

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr linked an issue Sep 5, 2022 that may be closed by this pull request
@AlexanderSehr AlexanderSehr marked this pull request as ready for review September 19, 2022 06:23
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 19, 2022 06:23
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) September 19, 2022 06:23
AlexanderSehr and others added 4 commits October 11, 2022 13:02
…endencies.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…ew-Certificate.ps1

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…endencies.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr AlexanderSehr requested a review from eriqua October 11, 2022 11:51
Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit e85b75b into main Oct 11, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_network_appGw branch October 11, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules [cat] testing category: testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Network/applicationGateways to new dependencies approach

2 participants