Skip to content

[Modules] Updated ApplicationSecurityGroups to new dependency approach#1889

Merged
AlexanderSehr merged 7 commits intomainfrom
users/alsehr/1791_Network_applicationSecurityGroups
Oct 6, 2022
Merged

[Modules] Updated ApplicationSecurityGroups to new dependency approach#1889
AlexanderSehr merged 7 commits intomainfrom
users/alsehr/1791_Network_applicationSecurityGroups

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@AlexanderSehr AlexanderSehr commented Sep 4, 2022

Description

  • Updated ApplicationSecurityGroups to new dependency approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Network: ApplicationSecurityGroups

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Sep 4, 2022
@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Sep 4, 2022
@AlexanderSehr AlexanderSehr mentioned this pull request Sep 4, 2022
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 4, 2022

Unit Test Results

52 tests   50 ✔️  25s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit 4ba4576.

@AlexanderSehr AlexanderSehr linked an issue Sep 5, 2022 that may be closed by this pull request
Update Network/applicationSecurityGroups to new dependencies approach #1946
Closed
@AlexanderSehr AlexanderSehr marked this pull request as ready for review September 18, 2022 22:06
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 18, 2022 22:06
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) September 18, 2022 22:08
eriqua
eriqua approved these changes Oct 6, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 32aa4cf into main Oct 6, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_Network_applicationSecurityGroups branch October 6, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels

[cat] modules category: modules [cat] testing category: testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Network/applicationSecurityGroups to new dependencies approach

2 participants

@AlexanderSehr @eriqua