Skip to content

[Modules] Updated Web/StaticSites to new dependencies approach#1898

Merged
AlexanderSehr merged 10 commits intomainfrom
users/alsehr/1791_Web_StaticSites
Sep 27, 2022
Merged

[Modules] Updated Web/StaticSites to new dependencies approach#1898
AlexanderSehr merged 10 commits intomainfrom
users/alsehr/1791_Web_StaticSites

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@AlexanderSehr AlexanderSehr commented Sep 5, 2022

Description

  • Updated Web/StaticSites to new dependencies approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Web: StaticSites

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@AlexanderSehr AlexanderSehr self-assigned this Sep 5, 2022
@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Sep 5, 2022
@AlexanderSehr AlexanderSehr mentioned this pull request Sep 5, 2022
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 5, 2022

Unit Test Results

  1 files    1 suites   33s ⏱️
54 tests 53 ✔️ 1 💤 0 ❌
61 runs  59 ✔️ 2 💤 0 ❌

Results for commit 7da5cf1.

@AlexanderSehr AlexanderSehr linked an issue Sep 5, 2022 that may be closed by this pull request
[Modules] Update Web/staticSites to new dependencies approach #1897
Closed
AlexanderSehr
AlexanderSehr commented Sep 18, 2022
View reviewed changes
@AlexanderSehr AlexanderSehr marked this pull request as ready for review September 18, 2022 22:03
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 18, 2022 22:03
@AlexanderSehr AlexanderSehr mentioned this pull request Sep 27, 2022
Merged
4 tasks
@eriqua eriqua added the [prio] high importance of the issue: high priority label Sep 27, 2022
eriqua
eriqua approved these changes Sep 27, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 9c750f8 into main Sep 27, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_Web_StaticSites branch September 27, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels

[cat] modules category: modules [cat] testing category: testing [prio] high importance of the issue: high priority

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Modules] Update Web/staticSites to new dependencies approach

2 participants

@AlexanderSehr @eriqua