Skip to content

[Modules] Updated ManagementGroup to new dependency approach#1995

Merged
AlexanderSehr merged 7 commits intomainfrom
users/alsehr/1791_ManagementGroup
Oct 10, 2022
Merged

[Modules] Updated ManagementGroup to new dependency approach#1995
AlexanderSehr merged 7 commits intomainfrom
users/alsehr/1791_ManagementGroup

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@AlexanderSehr AlexanderSehr commented Sep 9, 2022

Description

  • Updated ManagementGroup to new dependency approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Management: ManagementGroups

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Sep 9, 2022
@AlexanderSehr AlexanderSehr linked an issue Sep 9, 2022 that may be closed by this pull request
Update Management/managementGroups to new dependencies approach #1994
Closed
@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Sep 9, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 9, 2022 •
edited
Loading

Unit Test Results

  1 files    1 suites   30s ⏱️
47 tests 45 ✔️ 2 💤 0 ❌
54 runs  51 ✔️ 3 💤 0 ❌

Results for commit 30e7dbb.

♻️ This comment has been updated with latest results.

@MariusStorhaug MariusStorhaug self-requested a review September 15, 2022 15:47
@AlexanderSehr AlexanderSehr marked this pull request as ready for review September 18, 2022 21:52
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 18, 2022 21:52
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) September 18, 2022 21:52
@AlexanderSehr AlexanderSehr requested a review from eriqua October 10, 2022 18:16
eriqua
eriqua approved these changes Oct 10, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 736c432 into main Oct 10, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_ManagementGroup branch October 10, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eriqua eriqua eriqua approved these changes

@MariusStorhaug MariusStorhaug Awaiting requested review from MariusStorhaug

Assignees

@AlexanderSehr AlexanderSehr

Labels

[cat] modules category: modules [cat] testing category: testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Management/managementGroups to new dependencies approach

2 participants

@AlexanderSehr @eriqua