Skip to content

[Modules] Updated Network ExpressRouteCircuits to new dependencies approach#2056

Merged
AlexanderSehr merged 6 commits intomainfrom
users/alsehr/1791_Network_expressRouteCircuits
Oct 10, 2022
Merged

[Modules] Updated Network ExpressRouteCircuits to new dependencies approach#2056
AlexanderSehr merged 6 commits intomainfrom
users/alsehr/1791_Network_expressRouteCircuits

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@AlexanderSehr AlexanderSehr commented Sep 18, 2022

Description

  • Updated Network ExpressRouteCircuits to new dependencies approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Network: ExpressRouteCircuits

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Sep 18, 2022
@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Sep 18, 2022
@AlexanderSehr AlexanderSehr linked an issue Sep 18, 2022 that may be closed by this pull request
Update Network/expressRouteCircuits to new dependencies approach #2055
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 18, 2022

Unit Test Results

  1 files    1 suites   32s ⏱️
53 tests 52 ✔️ 1 💤 0 ❌
60 runs  58 ✔️ 2 💤 0 ❌

Results for commit b647b65.

@AlexanderSehr AlexanderSehr marked this pull request as ready for review September 18, 2022 21:40
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 18, 2022 21:40
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) September 18, 2022 21:40
AlexanderSehr and others added 2 commits October 10, 2022 08:49
@AlexanderSehr @eriqua
Update modules/Microsoft.Network/expressRouteCircuits/.test/common/de…
73deefd 
…ploy.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr
Updated docs
63367c1
@AlexanderSehr AlexanderSehr requested a review from eriqua October 10, 2022 06:53
eriqua
eriqua approved these changes Oct 10, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:ok

@AlexanderSehr AlexanderSehr merged commit a40017d into main Oct 10, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_Network_expressRouteCircuits branch October 10, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels

[cat] modules category: modules [cat] testing category: testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Network/expressRouteCircuits to new dependencies approach

2 participants

@AlexanderSehr @eriqua