Skip to content

[Modules] Updated EventGrid Topics to new dependencies approach#2086

Merged
AlexanderSehr merged 13 commits intomainfrom
users/alsehr/1791_EventGrid_topics
Oct 4, 2022
Merged

[Modules] Updated EventGrid Topics to new dependencies approach#2086
AlexanderSehr merged 13 commits intomainfrom
users/alsehr/1791_EventGrid_topics

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

Description

  • Updated EventGrid Topics to new dependencies approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
EventGrid: Topics

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 20, 2022 19:41
@AlexanderSehr AlexanderSehr self-assigned this Sep 20, 2022
@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Sep 20, 2022
@AlexanderSehr AlexanderSehr linked an issue Sep 20, 2022 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown

Unit Test Results

  1 files  ±  0    1 suites  ±0   42s ⏱️ -9s
55 tests  - 77  54 ✔️  - 76  1 💤  - 1  0 ±0 
72 runs   - 63  69 ✔️  - 64  3 💤 +1  0 ±0 

Results for commit 7ec1674. ± Comparison against base commit 1901349.

This pull request removes 132 and adds 55 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ContainerRegistry/registries/replications] used resource type [registries/replications] should use one of the recent API version(s). Currently using [2022-02-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ContainerRegistry/registries/webhooks] used resource type [registries/webhooks] should use one of the recent API version(s). Currently using [2022-02-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ContainerRegistry/registries] used resource type [diagnosticsettings] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ContainerRegistry/registries] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ContainerRegistry/registries] used resource type [privateEndpoints/privateDnsZoneGroups] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ContainerRegistry/registries] used resource type [privateEndpoints] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ContainerRegistry/registries] used resource type [registries/replications] should use one of the recent API version(s). Currently using [2022-02-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ContainerRegistry/registries] used resource type [registries/webhooks] should use one of the recent API version(s). Currently using [2022-02-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ContainerRegistry/registries] used resource type [registries] should use one of the recent API version(s). Currently using [2022-02-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ContainerRegistry/registries] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
…
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventGrid/topics] used resource type [diagnosticsettings] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventGrid/topics] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventGrid/topics] used resource type [privateEndpoints/privateDnsZoneGroups] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventGrid/topics] used resource type [privateEndpoints] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventGrid/topics] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventGrid/topics] used resource type [topics] should use one of the recent API version(s). Currently using [2020-06-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.EventGrid/topics] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.EventGrid/topics] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.EventGrid/topics] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.EventGrid/topics] All required parameters in template file (deploy.json) should exist in parameters files
…
This pull request removes 2 skipped tests and adds 1 skipped test. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.ContainerRegistry/registries/replications] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.ContainerRegistry/registries/webhooks] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.EventGrid/topics] *parameters.json files in the .test folder should be valid json

@AlexanderSehr AlexanderSehr enabled auto-merge (squash) September 28, 2022 15:07
AlexanderSehr and others added 6 commits October 3, 2022 22:20
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@eriqua eriqua added the [prio] high importance of the issue: high priority label Oct 4, 2022
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
AlexanderSehr and others added 2 commits October 4, 2022 19:10
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 2598d08 into main Oct 4, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_EventGrid_topics branch October 4, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules [cat] testing category: testing [prio] high importance of the issue: high priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update EventGrid/topics to new dependencies approach

2 participants