[Fixes] Fixed Readme files and Pester tests after recent new line change#2132
Merged
ahmadabdalla merged 2 commits intomainfrom Sep 25, 2022
Merged
[Fixes] Fixed Readme files and Pester tests after recent new line change#2132ahmadabdalla merged 2 commits intomainfrom
ahmadabdalla merged 2 commits intomainfrom
Conversation
MariusStorhaug
approved these changes
Sep 25, 2022
Contributor
MariusStorhaug
left a comment
There was a problem hiding this comment.
Thank you for fixing this bug @ahmadabdalla. This was introduced by a change I did on the readme generator, which I did as we played around with DocFX during the hack. When displaying the readmes it failed to show the tables correctly, and that is due to it sticking more strictly to the MD definition.
Contributor
Author
|
Thank you @MariusStorhaug |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2131
Description
Fixed an issue where the pester test validation is failing when attempting to validate the readme file of a module. This caused all modules static tests to fail and required to regenerate all the module readmes to fit the new parameter section extra line change
NOTE: Excluded the Synapse workspace module in this change as the template is not compiling for issues to related to this change.
Pipeline references
Type of Change
Checklist