Skip to content

[Modules] Images - Proposal for a slightly different structure#2136

Merged
eriqua merged 5 commits intousers/erikag/1921-images-newdepfrom
users/erikag/1921-images-newdep_alsehrTest
Sep 30, 2022
Merged

[Modules] Images - Proposal for a slightly different structure#2136
eriqua merged 5 commits intousers/erikag/1921-images-newdepfrom
users/erikag/1921-images-newdep_alsehrTest

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@AlexanderSehr AlexanderSehr commented Sep 27, 2022

Proposal for a slightly different structure

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 27, 2022 18:18
@AlexanderSehr AlexanderSehr self-assigned this Sep 27, 2022
@AlexanderSehr AlexanderSehr marked this pull request as draft September 27, 2022 18:19
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 27, 2022 •
edited
Loading

Unit Test Results

  1 files  ±  0    1 suites  ±0   26s ⏱️ +5s
60 tests +10  58 ✔️ +8  2 💤 +2  0 ❌ ±0 
60 runs  +  9  58 ✔️ +7  2 💤 +2  0 ❌ ±0 

Results for commit 0be3dae. ± Comparison against base commit 2b0b607.

This pull request removes 50 and adds 60 tests. Note that renamed tests count towards both. 
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Web/hostingEnvironments] used resource type [diagnosticsettings] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Web/hostingEnvironments] used resource type [hostingEnvironments] should use one of the recent API version(s). Currently using [2021-03-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Web/hostingEnvironments] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Web/hostingEnvironments] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Web/hostingEnvironments] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Web/hostingEnvironments] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Web/hostingEnvironments] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Web/hostingEnvironments] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Web/hostingEnvironments] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Web/hostingEnvironments] Conditional parameters' description should contain 'Required if' followed by the condition making the parameter required.
…

/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/images] used resource type [images] should use one of the recent API version(s). Currently using [2021-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/images] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/images] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/images] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/images] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/images] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/images] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/images] Conditional parameters' description should contain 'Required if' followed by the condition making the parameter required.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/images] If delete lock is implemented, the template should have a lock parameter with the default value of ['']
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/images] Location output should be returned for resources that use it
…

♻️ This comment has been updated with latest results.

@eriqua eriqua mentioned this pull request Sep 29, 2022
Merged
10 tasks
@eriqua eriqua changed the title Proposal for a slightly different structure [Modules] Images - Proposal for a slightly different structure Sep 30, 2022
@eriqua eriqua marked this pull request as ready for review September 30, 2022 10:06
eriqua
eriqua approved these changes Sep 30, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@eriqua eriqua merged commit 4d5de12 into users/erikag/1921-images-newdep Sep 30, 2022
@eriqua eriqua deleted the users/erikag/1921-images-newdep_alsehrTest branch September 30, 2022 10:07
eriqua added a commit that referenced this pull request Oct 4, 2022
@eriqua @AlexanderSehr @elanzel
[Modules] Updated Compute Images to new dependency approach (#2019)
17f642e 
* update workflow

* test draft dep

* test draft dep sa

* readme

* role assignment

* 2 dep

* disable pester

* managedIdentityResourceId

* customize

* customize restart

* distribute

* rbac

* basetime

* imageTemplateNamePrefix

* managedIdentityName var

* triggerImageDeploymentScript

* copyVhdDeploymentScript

* validation

* readme

* output and dependson

* dep descriptions

* container

* ps version

* cleanup

* Get-AzImageBuilderTemplateRunOutput

* Update modules/Microsoft.Compute/images/.test/common/deploy.test.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update modules/Microsoft.Compute/images/.test/common/deploy.test.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update modules/Microsoft.Compute/images/.test/common/deploy.test.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* no img

* test remove rolea prio

* reenable

* Proposal 1 (#2136)

Co-authored-by: Erika Gressi <erikag@microsoft.com>

* update naming

* readme

* no version update

* hosting env draft new dependencies

* added nsg

* description .

* rollback ase

* rollback ase pipeline

* remove comment

* add metadata to nested rbac param

* Update deploy.test.bicep

Remove vars

* Update dependencies.bicep

Use storageAccount output

* Update deploy.test.bicep

Remove destinationStorageAccount

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Elisa Anzelmo <elisa.anzelmo@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexanderSehr @eriqua