Skip to content

[Modules] Update Compute Disks to new dependencies approach#2239

Merged
eriqua merged 10 commits intomainfrom
users/erikag/1926-disks-newdep
Oct 20, 2022
Merged

[Modules] Update Compute Disks to new dependencies approach#2239
eriqua merged 10 commits intomainfrom
users/erikag/1926-disks-newdep

Conversation

@eriqua
Copy link
Copy Markdown
Contributor

@eriqua eriqua commented Oct 19, 2022

Description

Thank you for your contribution !

Please include a summary of the change and which issue is fixed.
Please also include the context.
List any dependencies that are required for this change.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Compute: Disks

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua requested a review from a team as a code owner October 19, 2022 23:36
@eriqua eriqua linked an issue Oct 19, 2022 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@ahmadabdalla ahmadabdalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@eriqua eriqua merged commit 554a758 into main Oct 20, 2022
@eriqua eriqua deleted the users/erikag/1926-disks-newdep branch October 20, 2022 00:31
@eriqua eriqua added enhancement New feature or request [cat] modules category: modules [cat] testing category: testing hacktoberfest-accepted labels Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules [cat] testing category: testing enhancement New feature or request hacktoberfest-accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Compute/disks to new dependencies approach

2 participants