Skip to content

[Modules] Updated VirtualMachineImages\ImageTemplate to new dependencies approach#2250

Merged
fabmas merged 13 commits intomainfrom
users/fabmas/2226_vmimages
Oct 26, 2022
Merged

[Modules] Updated VirtualMachineImages\ImageTemplate to new dependencies approach#2250
fabmas merged 13 commits intomainfrom
users/fabmas/2226_vmimages

Conversation

@fabmas
Copy link
Copy Markdown
Member

@fabmas fabmas commented Oct 25, 2022

Description

Updated VirtualMachineImages\ImageTemplate to new dependencies approach

close #2226

Pipeline references

Pipeline
VirtualMachineImages: ImageTemplates

Type of Change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@fabmas fabmas added [cat] modules category: modules [cat] testing category: testing labels Oct 25, 2022
@fabmas fabmas requested a review from eriqua October 25, 2022 11:29
@fabmas fabmas requested a review from a team as a code owner October 25, 2022 11:29
eriqua
eriqua reviewed Oct 25, 2022
View reviewed changes
AlexanderSehr and others added 5 commits October 25, 2022 18:35
@AlexanderSehr
Adjusted implementation for testing (#2251)
90d398a
@fabmas @eriqua
Update modules/Microsoft.VirtualMachineImages/imageTemplates/.test/co…
acbb968 
…mmon/deploy.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@fabmas @eriqua
Update modules/Microsoft.VirtualMachineImages/imageTemplates/.test/co…
0d609d7 
…mmon/deploy.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@fabmas @eriqua
Update modules/Microsoft.VirtualMachineImages/imageTemplates/.test/co…
4e9047c 
…mmon/deploy.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@fabmas
updated readme
73f6876
@fabmas fabmas requested a review from eriqua October 26, 2022 13:53
@fabmas fabmas enabled auto-merge (squash) October 26, 2022 13:54
@fabmas fabmas closed this Oct 26, 2022
auto-merge was automatically disabled October 26, 2022 13:54

Pull request was closed

@fabmas fabmas reopened this Oct 26, 2022
@fabmas fabmas enabled auto-merge (squash) October 26, 2022 13:55
eriqua
eriqua approved these changes Oct 26, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@fabmas fabmas merged commit aff7708 into main Oct 26, 2022
@fabmas fabmas deleted the users/fabmas/2226_vmimages branch October 26, 2022 14:57
@eriqua eriqua changed the title [modules] Updated VirtualMachineImages\ImageTemplate to new dependencies approach [Modules] Updated VirtualMachineImages\ImageTemplate to new dependencies approach Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr left review comments

@eriqua eriqua eriqua approved these changes

Assignees

@fabmas fabmas

@elanzel elanzel

Labels

[cat] modules category: modules [cat] testing category: testing hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update VirtualMachineImages/imageTemplates to new dependencies approach

4 participants

@fabmas @AlexanderSehr @eriqua @elanzel