[Modules] Converted Network NetworkWatcher to new dependencies approach by AlexanderSehr · Pull Request #2273 · Azure/ResourceModules

AlexanderSehr · 2022-11-04T14:26:24Z

Description

Converted Network NetworkWatcher to new dependencies approach
Update removal logic to NOT remove the Resource Group NetworkWatcherRG as otherwise the tests would conflict

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline

Type of Change

Please delete options that are not relevant.

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Update to documentation

github-actions · 2022-11-04T14:36:15Z

Unit Test Results

    1 files ±    0     1 suites ±0 56s ⏱️ +51s
126 tests +115 125 ✔️ +115 1 💤 ±0 0 ❌ ±0
133 runs +117 131 ✔️ +121 2 💤 - 4 0 ❌ ±0

Results for commit c66ac9c. ± Comparison against base commit 5f0723e.

This pull request removes 11 and adds 126 tests. Note that renamed tests count towards both.

/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Compute/virtualMachines] *parameters.json files in the .test folder should be valid json
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Compute/virtualMachines] folder should contain one or more *parameters.json files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.Compute/virtualMachines/extensions] Module should contain a [deploy.json/deploy.bicep] file
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.Compute/virtualMachines/extensions] Module should contain a [readme.md] file
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.Compute/virtualMachines/extensions] Module should contain a [version.json] file
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.Compute/virtualMachines] Module should contain a [.test] folder
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.Compute/virtualMachines] Module should contain a [deploy.json/deploy.bicep] file
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.Compute/virtualMachines] Module should contain a [readme.md] file
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.Compute/virtualMachines] Module should contain a [version.json] file
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.Compute/virtualMachines] Module should have a GitHub workflow
…

/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/networkWatchers/connectionMonitors] used resource type [networkWatchers/connectionMonitors] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/networkWatchers/flowLogs] used resource type [networkWatchers/flowLogs] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/networkWatchers] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/networkWatchers] used resource type [networkWatchers/connectionMonitors] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/networkWatchers] used resource type [networkWatchers/flowLogs] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/networkWatchers] used resource type [networkWatchers] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/networkWatchers] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/networkWatchers/connectionMonitors] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/networkWatchers/connectionMonitors] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/networkWatchers/connectionMonitors] All parameters in parameters files exist in template file (deploy.json)
…

This pull request removes 1 skipped test and adds 1 skipped test. Note that renamed tests count towards both.

/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Compute/virtualMachines] *parameters.json files in the .test folder should be valid json

/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Network/networkWatchers] *parameters.json files in the .test folder should be valid json

♻️ This comment has been updated with latest results.

utilities/pipelines/resourceRemoval/helper/Remove-Deployment.ps1

modules/Microsoft.Network/networkWatchers/.test/min/deploy.test.bicep

modules/Microsoft.Network/networkWatchers/.test/common/dependencies.bicep

modules/Microsoft.Network/networkWatchers/.test/common/deploy.test.bicep

eriqua

🆗

AlexanderSehr added 7 commits November 4, 2022 09:04

Init

deed500

Update to latest

42f3a4b

Added first draft of vm dep

3a9a013

Update to latest

2114f20

Update to latest

c3e6eff

Excluded NetworkWatcher from removal

37c4b56

Excluded NetworkWatcher from removal

b759ca9

AlexanderSehr linked an issue Nov 4, 2022 that may be closed by this pull request

Update Network/networkWatchers to new dependencies approach #2270

Closed

AlexanderSehr self-assigned this Nov 4, 2022

AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Nov 4, 2022

AlexanderSehr added 2 commits November 4, 2022 15:28

Enabled removal in pipelines

e7fd204

Adjusted tests & docs

03454e1

AlexanderSehr added 2 commits November 4, 2022 15:49

Update to latest

c66ac9c

Added disk removal

1cbd24e

AlexanderSehr marked this pull request as ready for review November 4, 2022 15:34

AlexanderSehr requested a review from a team as a code owner November 4, 2022 15:34

AlexanderSehr enabled auto-merge (squash) November 4, 2022 15:35

eriqua reviewed Nov 4, 2022

View reviewed changes

utilities/pipelines/resourceRemoval/helper/Remove-Deployment.ps1 Show resolved Hide resolved

Update to latest

43add07

AlexanderSehr requested a review from eriqua November 4, 2022 21:02

eriqua mentioned this pull request Nov 8, 2022

[CI environment] Old dependencies approach clean up #2297

Merged

10 tasks

AlexanderSehr commented Nov 9, 2022

View reviewed changes

modules/Microsoft.Network/networkWatchers/.test/min/deploy.test.bicep Show resolved Hide resolved

Added comment

f05c219

eriqua reviewed Nov 9, 2022

View reviewed changes

modules/Microsoft.Network/networkWatchers/.test/common/dependencies.bicep Show resolved Hide resolved

eriqua reviewed Nov 9, 2022

View reviewed changes

modules/Microsoft.Network/networkWatchers/.test/common/deploy.test.bicep Outdated Show resolved Hide resolved

eriqua reviewed Nov 9, 2022

View reviewed changes

modules/Microsoft.Network/networkWatchers/.test/common/deploy.test.bicep Outdated Show resolved Hide resolved

eriqua reviewed Nov 9, 2022

View reviewed changes

modules/Microsoft.Network/networkWatchers/.test/common/deploy.test.bicep Outdated Show resolved Hide resolved

Addressed comments

42e58d6

AlexanderSehr added 2 commits November 10, 2022 18:05

Update to latest

0401901

Updated names

d6f9b13

AlexanderSehr requested a review from eriqua November 10, 2022 23:52

Updated names

c0f6fd7

eriqua approved these changes Nov 11, 2022

View reviewed changes

AlexanderSehr merged commit 2d08718 into main Nov 11, 2022

AlexanderSehr deleted the users/alsehr/1791_Network_networkWatcher branch November 11, 2022 10:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Modules] Converted Network NetworkWatcher to new dependencies approach#2273

[Modules] Converted Network NetworkWatcher to new dependencies approach#2273
AlexanderSehr merged 17 commits intomainfrom
users/alsehr/1791_Network_networkWatcher

AlexanderSehr commented Nov 4, 2022 •

edited

Loading

Uh oh!

github-actions bot commented Nov 4, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eriqua left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

AlexanderSehr commented Nov 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pipeline references

Type of Change

Uh oh!

github-actions bot commented Nov 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eriqua left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AlexanderSehr commented Nov 4, 2022 •

edited

Loading

github-actions bot commented Nov 4, 2022 •

edited

Loading