Skip to content

[Modules] Update SQL MI to new dependencies approach#2316

Merged
eriqua merged 51 commits intomainfrom
users/erikag/1964-sqlmi-newdep
Nov 12, 2022
Merged

[Modules] Update SQL MI to new dependencies approach#2316
eriqua merged 51 commits intomainfrom
users/erikag/1964-sqlmi-newdep

Conversation

@eriqua
Copy link
Copy Markdown
Contributor

@eriqua eriqua commented Nov 11, 2022

Description

  • Converting to new dependencies approach
  • Fixed dependency between keys and encryption object

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Sql: ManagedInstances

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua linked an issue Nov 11, 2022 that may be closed by this pull request
@eriqua eriqua added enhancement New feature or request [cat] modules category: modules [cat] testing category: testing labels Nov 11, 2022
@github-actions
Copy link
Copy Markdown

Test Results

    1 files  ±    0      1 suites  ±0   2m 31s ⏱️ - 1m 54s
353 tests  - 221  346 ✔️  - 218  7 💤  - 3  0 ±0 
363 runs   - 228  355 ✔️  - 224  8 💤  - 4  0 ±0 

Results for commit a95faf6. ± Comparison against base commit c95069d.

@eriqua eriqua marked this pull request as ready for review November 12, 2022 11:30
@eriqua eriqua requested a review from a team as a code owner November 12, 2022 11:30
@eriqua eriqua enabled auto-merge (squash) November 12, 2022 11:30
@eriqua eriqua merged commit 0f646a5 into main Nov 12, 2022
@eriqua eriqua deleted the users/erikag/1964-sqlmi-newdep branch November 12, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules [cat] testing category: testing enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Sql/managedInstances to new dependencies approach

2 participants