Skip to content

[CI environment] Remove deploymentOutput from validate deployment action/pipeline template #2327

Closed
eriqua wants to merge 2 commits intomainfrom
users/erikag/2323-output
Closed

[CI environment] Remove deploymentOutput from validate deployment action/pipeline template #2327
eriqua wants to merge 2 commits intomainfrom
users/erikag/2323-output

Conversation

@eriqua
Copy link
Copy Markdown
Contributor

@eriqua eriqua commented Nov 13, 2022

Description

[DRAFT] Purpose of this PR is solely to show proposed (quick) fix to issue #2323

The deploymentOutput output parameter was originally added to the validate deployment action (GH) and pipeline template (ADO) to support pipeline orchestration for the dependencies pipeline.
With the new self-contained dependencies approach, the deploymentOutput output parameter is not used by the CI environment and could hence be removed together with its generation code snippet.

If accepted, the commented code should be removed and the change should be merged with PR #2297, currently blocked by issue #1791.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Synapse: Workspaces
AnalysisServices: Servers

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua
Copy link
Copy Markdown
Contributor Author

eriqua commented Nov 26, 2022

Updates included in #2297

@eriqua eriqua deleted the users/erikag/2323-output branch May 18, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant