Skip to content

[Modules] Updated Private Link Services to new dependencies approach#2342

Merged
ahmadabdalla merged 2 commits intomainfrom
users/ahmad/2339_plsDep
Nov 18, 2022
Merged

[Modules] Updated Private Link Services to new dependencies approach#2342
ahmadabdalla merged 2 commits intomainfrom
users/ahmad/2339_plsDep

Conversation

@ahmadabdalla
Copy link
Copy Markdown
Contributor

@ahmadabdalla ahmadabdalla commented Nov 18, 2022

closes #2339

Description

Updated Private link services module to the new dependency approach

Pipeline
Network: PrivateLinkServices

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla self-assigned this Nov 18, 2022
@ahmadabdalla ahmadabdalla added the [cat] modules category: modules label Nov 18, 2022
@ahmadabdalla ahmadabdalla added this to the Release v0.8.0 milestone Nov 18, 2022
@github-actions
Copy link
Copy Markdown

Test Results

  1 files    1 suites   32s ⏱️
52 tests 50 ✔️ 2 💤 0
62 runs  59 ✔️ 3 💤 0

Results for commit ffc1159.

@ahmadabdalla ahmadabdalla marked this pull request as ready for review November 18, 2022 06:25
@ahmadabdalla ahmadabdalla requested a review from a team as a code owner November 18, 2022 06:25
@ahmadabdalla ahmadabdalla merged commit 04cdcbb into main Nov 18, 2022
@ahmadabdalla ahmadabdalla deleted the users/ahmad/2339_plsDep branch November 18, 2022 09:53
@eriqua eriqua removed this from the Release v0.8.0 milestone Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Update Network/privateLinkServices to new dependencies approach

3 participants