Skip to content

[Modules] Enable Key Vault Purge Protection per default (disable in tests)#2343

Merged
SeSeicht merged 5 commits intoAzure:mainfrom
SeSeicht:kv
Nov 18, 2022
Merged

[Modules] Enable Key Vault Purge Protection per default (disable in tests)#2343
SeSeicht merged 5 commits intoAzure:mainfrom
SeSeicht:kv

Conversation

@SeSeicht
Copy link
Copy Markdown
Contributor

@SeSeicht SeSeicht commented Nov 18, 2022 •
edited
Loading

Description

fixes parts of: #783

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@SeSeicht SeSeicht requested a review from a team as a code owner November 18, 2022 14:06
@SeSeicht SeSeicht added the [cat] modules category: modules label Nov 18, 2022
@eriqua eriqua changed the title Enable Key Vault Purge Protection per default (disable in tests) [Modules] Enable Key Vault Purge Protection per default (disable in tests) Nov 18, 2022
@eriqua eriqua added the enhancement New feature or request label Nov 18, 2022
AlexanderSehr
AlexanderSehr reviewed Nov 18, 2022
View reviewed changes
AlexanderSehr
AlexanderSehr reviewed Nov 18, 2022
View reviewed changes
AlexanderSehr
AlexanderSehr previously approved these changes Nov 18, 2022
View reviewed changes
@SeSeicht SeSeicht enabled auto-merge (squash) November 18, 2022 22:24
@SeSeicht SeSeicht merged commit a80639f into Azure:main Nov 18, 2022
@SeSeicht SeSeicht linked an issue Dec 2, 2022 that may be closed by this pull request
Set default values to a secure value - Key Vault #783
Closed
@SeSeicht SeSeicht deleted the kv branch December 2, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@SeSeicht SeSeicht

Labels

[cat] modules category: modules enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Set default values to a secure value - Key Vault

3 participants

@SeSeicht @AlexanderSehr @eriqua