Skip to content

[Modules] Update Synapse Worskpace to new dependencies approach#2350

Merged
AlexanderSehr merged 43 commits intomainfrom
users/elbatane/2337_Synapse_worskpace_dependecy
Nov 28, 2022
Merged

[Modules] Update Synapse Worskpace to new dependencies approach#2350
AlexanderSehr merged 43 commits intomainfrom
users/elbatane/2337_Synapse_worskpace_dependecy

Conversation

@elbatane
Copy link
Copy Markdown
Contributor

@elbatane elbatane commented Nov 22, 2022

Description

Updated Synapse workspace to the new dependency model.

Changed 2 parameters to gain clarity on the module.

Fixed '<tenantId>' within Service Fabric Cluster as I missed it when I changed the module to the dependency model.

Close #2337

Pipeline references

Pipeline
Synapse: Workspaces
Service Fabric: Clusters

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@elbatane elbatane requested a review from a team as a code owner November 22, 2022 13:06
@eriqua eriqua changed the title [2337] synapse worskpace dependecy model [Modules] Update Synapse Worskpace to new dependecies approach Nov 22, 2022
@eriqua eriqua added enhancement New feature or request [cat] modules category: modules [cat] testing category: testing labels Nov 22, 2022
@AlexanderSehr AlexanderSehr changed the title [Modules] Update Synapse Worskpace to new dependecies approach [Modules] Update Synapse Worskpace to new dependencies approach Nov 25, 2022
@github-actions
Copy link
Copy Markdown

Test Results

    1 files  ±  0      1 suites  ±0   1m 4s ⏱️ +34s
  93 tests +41    91 ✔️ +41  2 💤 ±0  0 ±0 
133 runs  +71  127 ✔️ +68  6 💤 +3  0 ±0 

Results for commit f321857. ± Comparison against base commit 04cdcbb.

This pull request removes 52 and adds 93 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/privateLinkServices] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/privateLinkServices] used resource type [privateLinkServices] should use one of the recent API version(s). Currently using [2022-01-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/privateLinkServices] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/privateLinkServices] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/privateLinkServices] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/privateLinkServices] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/privateLinkServices] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/privateLinkServices] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/privateLinkServices] Conditional parameters' description should contain 'Required if' followed by the condition making the parameter required.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/privateLinkServices] If delete lock is implemented, the template should have a lock parameter with the default value of ['']
…
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Synapse/workspaces/keys] used resource type [workspaces/keys] should use one of the recent API version(s). Currently using [2021-06-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Synapse/workspaces] used resource type [diagnosticsettings] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Synapse/workspaces] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Synapse/workspaces] used resource type [privateEndpoints/privateDnsZoneGroups] should use one of the recent API version(s). Currently using [2022-05-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Synapse/workspaces] used resource type [privateEndpoints] should use one of the recent API version(s). Currently using [2022-05-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Synapse/workspaces] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Synapse/workspaces] used resource type [vaults/accessPolicies] should use one of the recent API version(s). Currently using [2021-06-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Synapse/workspaces] used resource type [workspaces/keys] should use one of the recent API version(s). Currently using [2021-06-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Synapse/workspaces] used resource type [workspaces] should use one of the recent API version(s). Currently using [2021-06-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Synapse/workspaces/keys] All apiVersion properties should be set to a static, hard-coded value
…
This pull request removes 2 skipped tests and adds 2 skipped tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/privateLinkServices] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Network/privateLinkServices] *parameters.json files in the .test folder should be valid json
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Synapse/workspaces/keys] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Synapse/workspaces] *parameters.json files in the .test folder should be valid json

@AlexanderSehr AlexanderSehr merged commit 1e4c334 into main Nov 28, 2022
@AlexanderSehr AlexanderSehr deleted the users/elbatane/2337_Synapse_worskpace_dependecy branch November 28, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules [cat] testing category: testing enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Synapse/workspaces to new dependencies approach

4 participants