[Modules] Added Key Module to SQL Server by fabmas · Pull Request #2438 · Azure/ResourceModules

fabmas · 2022-12-13T11:27:06Z

Description

Updated API versions
Added Key Module to SQL Server

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline

Type of Change

Please delete options that are not relevant.

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Update to documentation

Checklist

I'm sure there are no other open Pull Requests for the same update/change
My corresponding pipelines / checks run clean and green without any errors or warnings
My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation (readme)
I did format my code

…users/fabmas_2190_sql

modules/Microsoft.Sql/servers/.test/common/dependencies.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>

github-actions · 2022-12-14T07:56:51Z

Test Results

    1 files ±    0     1 suites ±0 2m 50s ⏱️ + 1m 26s
315 tests +190 309 ✔️ +189 6 💤 +1 0 ❌ ±0
335 runs +200 327 ✔️ +198 8 💤 +2 0 ❌ ±0

Results for commit 515e3e3. ± Comparison against base commit f8f2f6c.

This pull request removes 125 and adds 315 tests. Note that renamed tests count towards both.

/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/vpnGateways/connections] used resource type [vpnGateways/vpnConnections] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/vpnGateways/natRules] used resource type [vpnGateways/natRules] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/vpnGateways] used resource type [locks] should use one of the recent API version(s). Currently using [2020-05-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/vpnGateways] used resource type [vpnGateways/natRules] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/vpnGateways] used resource type [vpnGateways/vpnConnections] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/vpnGateways] used resource type [vpnGateways] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/vpnGateways/connections] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/vpnGateways/connections] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/vpnGateways/connections] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/vpnGateways/connections] All required parameters in template file (deploy.json) should exist in parameters files
…

/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Sql/servers/databases] used resource type [diagnosticsettings] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Sql/servers/databases] used resource type [servers/databases] should use one of the recent API version(s). Currently using [2021-11-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Sql/servers/elasticPools] used resource type [servers/elasticPools] should use one of the recent API version(s). Currently using [2022-02-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Sql/servers/firewallRules] used resource type [servers/firewallRules] should use one of the recent API version(s). Currently using [2022-02-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Sql/servers/keys] used resource type [servers/keys] should use one of the recent API version(s). Currently using [2022-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Sql/servers/securityAlertPolicies] used resource type [servers/securityAlertPolicies] should use one of the recent API version(s). Currently using [2022-02-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Sql/servers/virtualNetworkRules] used resource type [servers/virtualNetworkRules] should use one of the recent API version(s). Currently using [2022-02-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Sql/servers/vulnerabilityAssessments] used resource type [servers/vulnerabilityAssessments] should use one of the recent API version(s). Currently using [2022-02-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Sql/servers] used resource type [diagnosticsettings] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Sql/servers] used resource type [locks] should use one of the recent API version(s). Currently using [2020-05-01]
…

This pull request removes 5 skipped tests and adds 6 skipped tests. Note that renamed tests count towards both.

/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/vpnGateways/connections] Resource ID output should exist
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/vpnGateways/connections] Resource name output should exist
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/vpnGateways/connections] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/vpnGateways/natRules] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Network/vpnGateways] JSON test files in the .test folder should be valid json

/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Sql/servers/elasticPools] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Sql/servers/firewallRules] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Sql/servers/securityAlertPolicies] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Sql/servers/virtualNetworkRules] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Sql/servers/vulnerabilityAssessments] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Sql/servers] JSON test files in the .test folder should be valid json

eriqua

🆗

fabmas added 27 commits December 1, 2022 11:12

sqlserver_key_01

592685c

sqlserver_key_01

8d31f54

updated_readme

f26fbfa

updated readme file

d30ce6b

Merge branch 'main' of https://github.com/Azure/ResourceModules into …

b1de33a

…users/fabmas_2190_sql

readme keys

ec502e6

updates

a2351b6

'pippo_carml_sqlserver'

954bd76

fabmas permissions

dd125e3

principalType

4a8cdb6

doppie permissions

fd740e9

y

7930de4

readme

bf93cc0

rimosso pippo

2cd40ce

update

fad3924

update

313c352

dependency scope keyvault

6f8b2d0

added FabioPermissions

b7a2542

guid

2e0e8aa

owner

23b2588

managedidentity carml-scom

db720b0

systemmanagedidentity

6081fdd

systemidentity=false

94c9c3f

readme

5302481

systemidentity true

98684ce

primaryUserAssignedIdentity

72aa186

rimosso FabioPermissions

87d7c96

fabmas added enhancement New feature or request [cat] modules category: modules [cat] testing category: testing labels Dec 13, 2022

fabmas requested a review from a team as a code owner December 13, 2022 11:27

fabmas assigned fabmas and elanzel Dec 13, 2022

fabmas enabled auto-merge (squash) December 13, 2022 11:28

eriqua reviewed Dec 13, 2022

View reviewed changes

modules/Microsoft.Sql/servers/.test/common/dependencies.bicep Outdated Show resolved Hide resolved

eriqua reviewed Dec 13, 2022

View reviewed changes

modules/Microsoft.Sql/servers/.test/common/dependencies.bicep Outdated Show resolved Hide resolved

fabmas and others added 2 commits December 14, 2022 08:48

Update modules/Microsoft.Sql/servers/.test/common/dependencies.bicep

3c95d07

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>

KeyPermissions applied to Key

515e3e3

eriqua approved these changes Dec 17, 2022

View reviewed changes

fabmas merged commit 4aaac8d into main Dec 17, 2022

fabmas deleted the users/fabmas_2190_sql branch December 17, 2022 13:34

elanzel linked an issue Apr 14, 2023 that may be closed by this pull request

[Modules] Extend Microsoft.Sql\servers with keys child resource #2190

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Modules] Added Key Module to SQL Server#2438

[Modules] Added Key Module to SQL Server#2438
fabmas merged 29 commits intomainfrom
users/fabmas_2190_sql

fabmas commented Dec 13, 2022

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 14, 2022

Uh oh!

eriqua left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

fabmas commented Dec 13, 2022

Description

Pipeline references

Type of Change

Checklist

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 14, 2022

Test Results

Uh oh!

eriqua left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants