Skip to content

[Modules] Enable 'AllLogs' as diagnostic category#2443

Merged
SeSeicht merged 5 commits intomainfrom
users/seseicht/allLogsDiagSettings
Dec 19, 2022
Merged

[Modules] Enable 'AllLogs' as diagnostic category#2443
SeSeicht merged 5 commits intomainfrom
users/seseicht/allLogsDiagSettings

Conversation

@SeSeicht
Copy link
Copy Markdown
Contributor

@SeSeicht SeSeicht commented Dec 13, 2022 •
edited
Loading

Description

This will enable the Diagnostic Settings category "allLogs" and also sets the default for all Diagnostic Settings enabled Resources

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Network: VirtualNetworks

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@SeSeicht
Feature/all diag settings for all res (#2442)
e46b934 
* change allowed values and diagnosticLogCategori

* update readmes
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 13, 2022

Test Results

    1 files      1 suites   1m 10s ⏱️
128 tests 125 ✔️ 3 💤 0 ❌
145 runs  140 ✔️ 5 💤 0 ❌

Results for commit e46b934.

@SeSeicht SeSeicht linked an issue Dec 13, 2022 that may be closed by this pull request
Logs: Enable 'AllLogs' #1160
Closed
@SeSeicht SeSeicht marked this pull request as ready for review December 13, 2022 14:10
@SeSeicht SeSeicht requested a review from a team as a code owner December 13, 2022 14:10
@SeSeicht SeSeicht enabled auto-merge (squash) December 13, 2022 14:11
@AlexanderSehr AlexanderSehr changed the title Feature/all diag settings for all res (#2442) [Modules] Enable 'AllLogs' as diagnostic category Dec 13, 2022
eriqua
eriqua reviewed Dec 13, 2022
View reviewed changes
SeSeicht and others added 2 commits December 15, 2022 09:05
@SeSeicht
update frontDoor and gateway
4886a4c
@SeSeicht @eriqua
Update docs/wiki/The library - Module design.md
254d57a 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
eriqua
eriqua reviewed Dec 17, 2022
View reviewed changes
@SeSeicht SeSeicht merged commit 1aaad7c into main Dec 19, 2022
@SeSeicht SeSeicht deleted the users/seseicht/allLogsDiagSettings branch December 19, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eriqua eriqua eriqua left review comments

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@SeSeicht SeSeicht

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Logs: Enable 'AllLogs'

3 participants

@SeSeicht @AlexanderSehr @eriqua