[Modules] New Child Module Gallery Application#2465
[Modules] New Child Module Gallery Application#2465eriqua merged 16 commits intoAzure:mainfrom shawntmeyer:Gallery-Application
Conversation
modules/Microsoft.Compute/galleries/application/.bicep/nested_roleAssignments.bicep
Outdated
Show resolved
Hide resolved
modules/Microsoft.Compute/galleries/application/.bicep/nested_roleAssignments.bicep
Outdated
Show resolved
Hide resolved
modules/Microsoft.Compute/galleries/application/.bicep/nested_roleAssignments.bicep
Outdated
Show resolved
Hide resolved
modules/Microsoft.Compute/galleries/application/.bicep/nested_roleAssignments.bicep
Outdated
Show resolved
Hide resolved
modules/Microsoft.Compute/galleries/.test/applications/deploy.test.bicep
Outdated
Show resolved
Hide resolved
|
Erika, id be happy to merge the tests into the .common folder but this isnt how the .images folder was configured. Also, the images module uses the endOfLife which is not from reference. Should this be changed for consistency? |
@shawntmeyer you are right, the gallery test isn't configured as per test design. It should ideally have a common test where as many parameters and features are tested plus a min test where only the parent required parameters are tested. While we double check if there has been a good reason why it has been configured in that way (sometimes additional tests are required due to conflicting features) I'd suggest to skip the update of the image module and test for now, but only add the gallery applications deployment to the gallery common test. I'll open an issue for what you correctly pointed out so that we can fix it in a different PR. |
|
I added the applications test to the common test. |
Description
This module is for application definitions in the Azure Compute Gallery.
Checklist